New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists: trim rbd/rgw forced dependencies #16574

Merged
merged 1 commit into from Jul 27, 2017

Conversation

Projects
None yet
3 participants
@batrick
Member

batrick commented Jul 25, 2017

Signed-off-by: Patrick Donnelly pdonnell@redhat.com

CMakeLists: trim rbd/rgw accidental dependencies
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Objecter.cc
Filer.cc)
set(osdc_rbd_files
Filer.cc

This comment has been minimized.

@dillaman

dillaman Jul 26, 2017

Contributor

Aren't these already linked into librados? This could have the possibility of causing oddities.

This comment has been minimized.

@batrick

batrick Jul 26, 2017

Member

I may be misunderstanding the intent of this code but I believe there was no reason to break these osdc_rbd_files into a separate group which is why I merged them. Nothing else was referring to osdc_rbd_files.

This comment has been minimized.

@dillaman

dillaman Jul 26, 2017

Contributor

OK -- if nothing else was referring to them, sounds good to me.

@dillaman

lgtm

@tchaikov tchaikov merged commit 2531063 into ceph:master Jul 27, 2017

3 of 4 checks passed

make check (arm64) make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@batrick batrick deleted the batrick:rgw-rbd-stripped-build branch Sep 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment