New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/MgrMonitor: reset mgrdigest timer with new subscription #16582

Merged
merged 1 commit into from Jul 28, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Member

liewegas commented Jul 26, 2017

If the manager reconnects, we want to send the digest immediately and
reset the previous timer.

Fixes: http://tracker.ceph.com/issues/20633
Signed-off-by: Sage Weil sage@redhat.com

mon/MgrMonitor: reset mgrdigest timer with new subscription
If the manager reconnects, we want to send the digest immediately and
reset the previous timer.

Fixes: http://tracker.ceph.com/issues/20633
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas requested a review from jcsp Jul 26, 2017

@liewegas liewegas added this to the luminous milestone Jul 26, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 26, 2017

retest this please

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 27, 2017

retest this please

@liewegas liewegas requested a review from tchaikov Jul 27, 2017

@tchaikov tchaikov removed the needs-review label Jul 28, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 28, 2017

@liewegas is /a/sage-2017-07-27_13:38:00-rados-wip-sage-testing-distro-basic-smithi/1453121 a known issue? although it's not likely relevant.

 ceph version 12.1.1-715-gc75dd25 (c75dd2586d53155be161ac167b2805b3b7dbe9e7) luminous (rc)
 1: (()+0xa61221) [0x7ff9a4dd0221]
 2: (()+0xf370) [0x7ff9a1bbd370]
 3: (()+0xe1bd) [0x7ff9a1bbc1bd]
 4: (()+0x9d02) [0x7ff9a1bb7d02]
 5: (pthread_mutex_lock()+0x38) [0x7ff9a1bb7c08]
 6: (Mutex::Lock(bool)+0x48) [0x7ff9a4dee718]
 7: (OSD::do_recovery(PG*, unsigned int, unsigned long, ThreadPool::TPHandle&)+0x3fc) [0x7ff9a48a165c]
 8: (OSD::ShardedOpWQ::_process(unsigned int, ceph::heartbeat_handle_d*)+0xed9) [0x7ff9a48c1d19]
 9: (ShardedThreadPool::shardedthreadpool_worker(unsigned int)+0x839) [0x7ff9a4e14429]
 10: (ShardedThreadPool::WorkThreadSharded::entry()+0x10) [0x7ff9a4e163c0]
 11: (()+0x7dc5) [0x7ff9a1bb5dc5]
 12: (clone()+0x6d) [0x7ff9a0ca973d]

@tchaikov tchaikov merged commit 3c12075 into ceph:master Jul 28, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
@liewegas

This comment has been minimized.

Member

liewegas commented Jul 28, 2017

yeah, it's http://tracker.ceph.com/issues/20808 (new deadlock from the forced recovery code)

@liewegas liewegas deleted the liewegas:wip-20633 branch Jul 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment