New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fixes for test_pidfile #16587

Merged
merged 1 commit into from Jul 26, 2017

Conversation

Projects
None yet
2 participants
@dzafman
Member

dzafman commented Jul 26, 2017

Alternative fix for test_pidfile

I'm running this test in a loop overnight.

@dzafman dzafman requested a review from liewegas Jul 26, 2017

@liewegas

can we verify it works with -f for the second mon? if so this looks good!

@@ -52,7 +53,7 @@ function TEST_pidfile() {
run_mon $dir a 2>&1 | grep "failed to lock pidfile" || return 1

This comment has been minimized.

@liewegas

liewegas Jul 26, 2017

Member

we can pass -f for the mon here, too

@@ -33,6 +33,7 @@ function TEST_without_pidfile() {
--mkfs \
--mon-data=$data \
--run-dir=$dir || return 1
sleep 1

This comment has been minimized.

@liewegas

liewegas Jul 26, 2017

Member

i don't think this sleep des anything.. --mkfs runs and then exits, so nothing is running at this point

test: Fixes for test_pidfile
Add a short delay for one test
Fix test that had unreliable log output

Fixes: http://tracker.ceph.com/issues/20770

Signed-off-by: David Zafman <dzafman@redhat.com>
@dzafman

This comment has been minimized.

Member

dzafman commented Jul 26, 2017

retest this please

@dzafman dzafman merged commit 012ad6f into ceph:master Jul 26, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@dzafman dzafman deleted the dzafman:wip-20770 branch Jul 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment