New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore/StupidAllocator: rounded down len to an align boundary #16593

Merged
merged 1 commit into from Jul 28, 2017

Conversation

Projects
None yet
4 participants
@shangzhong
Contributor

shangzhong commented Jul 26, 2017

os/bluestore/StupidAllocator: rounded down len to an align boundary

Fixes: http://tracker.ceph.com/issues/20660
Signed-off-by: Zhu Shangzhong zhu.shangzhong@zte.com.cn

@shangzhong shangzhong changed the title from os/bluestore/StupidAllocator: rounded down the allocated length to an… to os/bluestore/StupidAllocator: rounded down len to an align boundary Jul 26, 2017

os/bluestore/StupidAllocator: rounded down len to an align boundary
Fixes: http://tracker.ceph.com/issues/20660
Signed-off-by: Zhu Shangzhong <zhu.shangzhong@zte.com.cn>

@liewegas liewegas added the needs-qa label Jul 26, 2017

@liewegas liewegas added this to the luminous milestone Jul 26, 2017

@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov

tchaikov Jul 28, 2017

Contributor

http://pulpito.ceph.com/kchai-2017-07-28_02:24:35-rados-wip-kefu-testing-distro-basic-mira/1454666/

2017-07-28 02:45:00.063379 7f2c5ab32d00  2 bluestore(/var/lib/ceph/osd/ceph-2) fsck 1570 objects, 609 of them sharded.
2017-07-28 02:45:00.063386 7f2c5ab32d00  2 bluestore(/var/lib/ceph/osd/ceph-2) fsck 5540 extents to 5002 blobs, 1716 spanning, 1762 shared.
2017-07-28 02:45:00.063390 7f2c5ab32d00  1 bluestore(/var/lib/ceph/osd/ceph-2) fsck finish with 29 errors in 47.732275 seconds
2017-07-28 02:45:00.063399 7f2c5ab32d00 -1 bluestore(/var/lib/ceph/osd/ceph-2) _mount fsck found 29 errors
2017-07-28 02:45:00.063402 7f2c5ab32d00 -1 osd.2 0 OSD:init: unable to mount object store

@liewegas @shangzhong could the failure above be related to this PR?

Contributor

tchaikov commented Jul 28, 2017

http://pulpito.ceph.com/kchai-2017-07-28_02:24:35-rados-wip-kefu-testing-distro-basic-mira/1454666/

2017-07-28 02:45:00.063379 7f2c5ab32d00  2 bluestore(/var/lib/ceph/osd/ceph-2) fsck 1570 objects, 609 of them sharded.
2017-07-28 02:45:00.063386 7f2c5ab32d00  2 bluestore(/var/lib/ceph/osd/ceph-2) fsck 5540 extents to 5002 blobs, 1716 spanning, 1762 shared.
2017-07-28 02:45:00.063390 7f2c5ab32d00  1 bluestore(/var/lib/ceph/osd/ceph-2) fsck finish with 29 errors in 47.732275 seconds
2017-07-28 02:45:00.063399 7f2c5ab32d00 -1 bluestore(/var/lib/ceph/osd/ceph-2) _mount fsck found 29 errors
2017-07-28 02:45:00.063402 7f2c5ab32d00 -1 osd.2 0 OSD:init: unable to mount object store

@liewegas @shangzhong could the failure above be related to this PR?

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Jul 28, 2017

Member

I don't think so; stupid allocator isn't used by default (and doesn't appear to be used in this test). Can you open an urgent ticket? This looks like a real bug!

Member

liewegas commented Jul 28, 2017

I don't think so; stupid allocator isn't used by default (and doesn't appear to be used in this test). Can you open an urgent ticket? This looks like a real bug!

@tchaikov

This comment has been minimized.

Show comment
Hide comment
Contributor

tchaikov commented Jul 28, 2017

@tchaikov tchaikov merged commit 55a3e57 into ceph:master Jul 28, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@shangzhong shangzhong deleted the shangzhong:wip-20660 branch Jul 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment