New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osdc/Objecter: unify disparate EAGAIN handling paths into one #16627

Merged
merged 1 commit into from Jul 30, 2017

Conversation

Projects
None yet
4 participants
@liewegas
Member

liewegas commented Jul 27, 2017

We had two different code paths for EAGAIN that both
seemed to resend the same request again (with a new
tid), but implemneted it in two different ways. Further,
the first one was conditioned on the BALANCE_READS
flag but not LOCALIZED_READS, which should (I think) be
equivalent in this context.

Unify them into a single path.

Signed-off-by: Sage Weil sage@redhat.com

sl.unlock();
put_session(s);
op->tid = 0;
op->target.flags &= ~CEPH_OSD_FLAG_BALANCE_READS;

This comment has been minimized.

@dillaman

dillaman Jul 27, 2017

Contributor

Nit: remove localize read flag as well?

osdc/Objecter: unify disparate EAGAIN handling paths into one
We had two different code paths for EAGAIN that both
seemed to resend the same request again (with a new
tid), but implemneted it in two different ways. Further,
the first one was conditioned on the BALANCE_READS
flag but not LOCALIZED_READS, which should (I think) be
equivalent in this context.

Unify them into a single path.

Signed-off-by: Sage Weil <sage@redhat.com>
@gregsfortytwo

Reviewed-by: Greg Farnum gfarnum@redhat.com

@tchaikov tchaikov added this to the luminous milestone Jul 28, 2017

@tchaikov tchaikov merged commit 729cf44 into ceph:master Jul 30, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 30, 2017

@dillaman sorry, i jumped the gun. did you get a chance to run this patch thru RBD fsx tests? or do we have a tracker ticket tracking that issue?

@dillaman

This comment has been minimized.

Contributor

dillaman commented Jul 30, 2017

@tchaikov No worries -- I'll check the test runs on Monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment