New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: Use comparison instead of assignment #16653

Merged
merged 1 commit into from Aug 1, 2017

Conversation

Projects
None yet
5 participants
@amitkumar50
Contributor

amitkumar50 commented Jul 28, 2017

Fixed:

** CID 1409697 (#1 of 1): Assign instead of compare (PW.ASSIGN_WHERE_COMPARE_MEANT)

  1. assign_where_compare_meant: use of "=" where "==" may have been intended
  2. primary_file: During compilation of file '/src/rgw/librgw.cc'

Signed-off-by: Amit Kumar amitkuma@redhat.com

@tchaikov tchaikov requested a review from adamemerson Jul 28, 2017

@tchaikov tchaikov added the rgw label Jul 28, 2017

@adamemerson

Lend Grace, Thanks, Mea-culpa

@joscollin joscollin added the bug fix label Jul 28, 2017

rgw: Assign instead of compare
Fixed:

** CID 1409697 (#1 of 1): Assign instead of compare (PW.ASSIGN_WHERE_COMPARE_MEANT)
1. assign_where_compare_meant: use of "=" where "==" may have been intended
2. primary_file: During compilation of file '/src/rgw/librgw.cc'

Signed-off-by: Amit Kumar amitkuma@redhat.com

@joscollin joscollin changed the title from rgw: Assign instead of compare to rgw: Use comparison instead of assignment Aug 1, 2017

@joscollin joscollin merged commit 8669a70 into ceph:master Aug 1, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment