Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
throttle: Minimal destructor fix for Luminous #16661
gregsfortytwo left a comment
Is SimpleThrottle okay? There's nothing here that touches it and I didn't see anything apparent about why its signal waiter won't break in the same way.
I'm a little concerned about the tests since they don't seem to have caught the mis-matched
And there's the exceptions thing, but the rest of the changes look good. I didn't know about make_scope_guard(); that's pretty nice to have in the toolkit instead of custom-building an RAII struct every time!
@adamemerson yeah, please merge it once