New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/osd: kill compile warning #16669

Merged
merged 1 commit into from Jul 29, 2017

Conversation

Projects
None yet
2 participants
@Yan-waller
Contributor

Yan-waller commented Jul 29, 2017

[ 88%] Building CXX object src/tools/CMakeFiles/ceph-objectstore-tool.dir/ceph_objectstore_tool.cc.o
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/osd/TestPGLog.cc: In member function ‘virtual void PGLogTrimTest_TestTrimNoDups_Test::TestBody()’:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/osd/TestPGLog.cc:2796:165: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null]
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/osd/TestPGLog.cc: In member function ‘virtual void PGLogTrimTest_TestNoTrim_Test::TestBody()’:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/osd/TestPGLog.cc:2824:165: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null]
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/osd/TestPGLog.cc: In member function ‘virtual void PGLogTrimTest_TestGetRequest_Test::TestBody()’:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/osd/TestPGLog.cc:2909:165: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null]

Signed-off-by: Yan Jun yan.jun8@zte.com.cn

test/osd: kill compile warning
Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>
@xiexingguo

lgtm, the warnings are gone

@xiexingguo xiexingguo merged commit a977599 into ceph:master Jul 29, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
@xiexingguo

This comment has been minimized.

Member

xiexingguo commented Jul 29, 2017

@Yan-waller There is another warning introduced by the newly merged PR #16667 you might be interesting:


[ 31%] Building CXX object src/test/librados_test_stub/CMakeFiles/rados_test_stub.dir/TestMemIoCtxImpl.cc.o
/home/jenkins-build/build/workspace/ceph-pull-requests/src/cls/rbd/cls_rbd.cc: In function ‘int trash_list(cls_method_context_t, ceph::bufferlist*, ceph::bufferlist*)’:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/cls/rbd/cls_rbd.cc:5049:7: warning: unused variable ‘max_read’ [-Wunused-variable]
   int max_read = RBD_MAX_KEYS_READ;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment