New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: clear result in BlueRocksEnv::getChildren #16683

Merged
merged 1 commit into from Aug 3, 2017

Conversation

Projects
None yet
3 participants
@Liuchang0812
Contributor

Liuchang0812 commented Jul 31, 2017

see https://github.com/facebook/rocksdb/blob/master/env/env_posix.cc#L492. in
rocksdb::env_posix implementation, it will always clear result at first. We will
get a core dump when we use rocksdb::RepairDB if we do not clear result.

Fixes: http://tracker.ceph.com/issues/20857

Signed-off-by: liuchang0812 liuchang0812@gmail.com

@tchaikov tchaikov requested a review from liewegas Jul 31, 2017

os/bluestore: clear result in BlueRocksEnv::getChildren
see https://github.com/facebook/rocksdb/blob/master/env/env_posix.cc#L492. in
rocksdb::env_posix implementation, it will always clear result at first. We will
get a core dump when we use rocksdb::RepairDB if we do not clear result.

Fixes: http://tracker.ceph.com/issues/20857

Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
@Liuchang0812

This comment has been minimized.

Show comment
Hide comment
@Liuchang0812

Liuchang0812 Jul 31, 2017

Contributor

jenkins test this please

Contributor

Liuchang0812 commented Jul 31, 2017

jenkins test this please

@Liuchang0812

This comment has been minimized.

Show comment
Hide comment
@Liuchang0812

Liuchang0812 Jul 31, 2017

Contributor

jenkins test this please

(make check passed, make check(arm64) failed)

Contributor

Liuchang0812 commented Jul 31, 2017

jenkins test this please

(make check passed, make check(arm64) failed)

@Liuchang0812

This comment has been minimized.

Show comment
Hide comment
@Liuchang0812

Liuchang0812 Jul 31, 2017

Contributor

jenkins test this please

Contributor

Liuchang0812 commented Jul 31, 2017

jenkins test this please

@Liuchang0812

This comment has been minimized.

Show comment
Hide comment
@Liuchang0812

Liuchang0812 Jul 31, 2017

Contributor

it seems that there are some problems in jenkins

Traceback (most recent call last):
  File "/usr/lib/python2.7/logging/handlers.py", line 76, in emit
    if self.shouldRollover(record):
  File "/usr/lib/python2.7/logging/handlers.py", line 154, in shouldRollover
    self.stream = self._open()
  File "/tmp/ceph-detect-init-virtualenv/local/lib/python2.7/site-packages/pip/utils/logging.py", line 121, in _open
    return logging.handlers.RotatingFileHandler._open(self)
  File "/usr/lib/python2.7/logging/__init__.py", line 943, in _open
    stream = open(self.baseFilename, self.mode)
IOError: [Errno 13] Permission denied: '/tmp/ceph-detect-init-virtualenv/log.txt'
Logged from file index.py, line 424
Contributor

Liuchang0812 commented Jul 31, 2017

it seems that there are some problems in jenkins

Traceback (most recent call last):
  File "/usr/lib/python2.7/logging/handlers.py", line 76, in emit
    if self.shouldRollover(record):
  File "/usr/lib/python2.7/logging/handlers.py", line 154, in shouldRollover
    self.stream = self._open()
  File "/tmp/ceph-detect-init-virtualenv/local/lib/python2.7/site-packages/pip/utils/logging.py", line 121, in _open
    return logging.handlers.RotatingFileHandler._open(self)
  File "/usr/lib/python2.7/logging/__init__.py", line 943, in _open
    stream = open(self.baseFilename, self.mode)
IOError: [Errno 13] Permission denied: '/tmp/ceph-detect-init-virtualenv/log.txt'
Logged from file index.py, line 424

@liewegas liewegas added this to the luminous milestone Aug 1, 2017

@tchaikov tchaikov merged commit 088f981 into ceph:master Aug 3, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@Liuchang0812 Liuchang0812 deleted the Liuchang0812:clear-result-in-getchildren branch Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment