Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybind/rados: use new APIs instead of deprecated ones #16684

Merged
merged 1 commit into from Aug 2, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Copy link
Contributor

tchaikov commented Jul 31, 2017

s/rados_read_op_omap_get_vals/rados_read_op_omap_get_vals2/
s/rados_read_op_omap_get_keys/rados_read_op_omap_get_keys2/

Signed-off-by: Kefu Chai kchai@redhat.com

pybind/rados: use new APIs instead of deprecated ones
s/rados_read_op_omap_get_vals/rados_read_op_omap_get_vals2/
s/rados_read_op_omap_get_keys/rados_read_op_omap_get_keys2/

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested a review from jdurgin Jul 31, 2017

@tchaikov tchaikov added this to the luminous milestone Jul 31, 2017

@jdurgin

jdurgin approved these changes Aug 1, 2017

Copy link
Member

jdurgin left a comment

functionally identical, avoids the warning

rados_read_op_omap_get_vals(_read_op.read_op, _start_after, _filter_prefix,
_max_return, &iter_addr, &prval)
rados_read_op_omap_get_vals2(_read_op.read_op, _start_after, _filter_prefix,
_max_return, &iter_addr, NULL, &prval)

This comment has been minimized.

Copy link
@liewegas

liewegas Aug 2, 2017

Member

That's the new 'bool more' arg, right? Shouldn't the wrapper be checking that so that the iterator wrapper can reliably report when it has reached the end?

@liewegas liewegas merged commit 8714c70 into ceph:master Aug 2, 2017

0 of 4 checks passed

Signed-off-by Build triggered. sha1 is merged.
Details
Unmodified Submodules Build triggered. sha1 is merged.
Details
make check Build triggered. sha1 is merged.
Details
make check (arm64) running make check
Details

@tchaikov tchaikov deleted the tchaikov:wip-pybind-replace-deprecated-apis branch Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.