New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: 1351525 Argument cannot be negative #16686

Merged
merged 1 commit into from Jul 31, 2017

Conversation

Projects
None yet
4 participants
@amitkumar50
Contributor

amitkumar50 commented Jul 31, 2017

Fixed:

** CID 1351525 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS)
7. negative_returns: sd is passed to a parameter that cannot be negative.

Signed-off-by: Amit Kumar amitkuma@redhat.com

@joscollin

Looks Good. Please update the coverity report with the PR url.

@joscollin joscollin added the needs-qa label Jul 31, 2017

@amitkumar50

This comment has been minimized.

Contributor

amitkumar50 commented Jul 31, 2017

@joscollin Thanks for Update.. Done..

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 31, 2017

@amitkumar50 could you improve the title of your commit message, so it summarizes the change instead of repeating the warning message? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#title-of-pull-requests-and-title-of-commits

@tchaikov tchaikov requested a review from dillaman Jul 31, 2017

@dillaman

lgtm

@joscollin

This comment has been minimized.

Member

joscollin commented Jul 31, 2017

Jenkins retest this please

rbd: 1351525 Argument cannot be negative
Fixed:

** CID 1351525 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS)
7. negative_returns: sd is passed to a parameter that cannot be negative.

Signed-off-by: Amit Kumar amitkuma@redhat.com

@dillaman dillaman merged commit a2857c8 into ceph:master Jul 31, 2017

3 of 4 checks passed

make check (arm64) running make check
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment