New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: Argument cannot be negative #16688

Merged
merged 1 commit into from Aug 1, 2017

Conversation

Projects
None yet
3 participants
@amitkumar50
Contributor

amitkumar50 commented Jul 31, 2017

Fixed:

** CID 1395347 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS)
3. negative_returns: fd is passed to a parameter that cannot be negative

Signed-off-by: Amit Kumar amitkuma@redhat.com

@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Jul 31, 2017

Jenkins test this please

@@ -452,6 +452,10 @@ TEST_F(TestLFNIndex, get_mangled_name) {
int main(int argc, char **argv) {
int fd = ::creat("detect", 0600);
if (fd < 0){
cerr << "failed to create detect" << std::endl;

This comment has been minimized.

@gregsfortytwo

gregsfortytwo Jul 31, 2017

Member

How about "failed to create file 'detect'" instead?

This comment has been minimized.

@amitkumar50

amitkumar50 Aug 1, 2017

Contributor

@gregsfortytwo Yeah that's Good Log to understand. Thanks!!!

@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Jul 31, 2017

Little error message nit but I'm happy to merge this. Just waiting because Jenkins got stuck again.

@joscollin

This comment has been minimized.

Member

joscollin commented Aug 1, 2017

Jenkins test this please

os: Argument cannot be negative
Fixed:

** CID 1395347 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS)
3. negative_returns: fd is passed to a parameter that cannot be negative

Signed-off-by: Amit Kumar amitkuma@redhat.com
@gregsfortytwo

Reviewed-by: Greg Farnum gfarnum@redhat.com

@gregsfortytwo gregsfortytwo merged commit 65e1154 into ceph:master Aug 1, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment