New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: disable -fvar-tracking-assignments for config.cc #16695

Merged
merged 1 commit into from Jul 31, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented Jul 31, 2017

there are too many variables involved in config.cc, but
-fvar-tracking-assignments is enabled by default, when the compiler
finds that the number of variables exceeds the limit
"max-vartrack-size", it gives up, and tries again disabling this
option.

this change avoids the recompilation of config.cc and also
silences the warning of

src/common/config.cc:77:1: note: variable tracking size limit exceeded
with -fvar-tracking-assignments, retrying without
md_config_t::md_config_t(bool is_daemon)
^

Signed-off-by: Kefu Chai kchai@redhat.com

cmake: disable -fvar-tracking-assignments for config.cc
there are too many variables involved in config.cc, but
-fvar-tracking-assignments is enabled by default, when the compiler
finds that the number of variables exceeds the limit
"max-vartrack-size", it gives up, and tries again disabling this
option.

this change avoids the recompilation of config.cc and also
silences the warning of

src/common/config.cc:77:1: note: variable tracking size limit exceeded
with -fvar-tracking-assignments, retrying without
 md_config_t::md_config_t(bool is_daemon)
 ^

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested a review from cbodley Jul 31, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 31, 2017

see https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=centos7,DIST=centos7,MACHINE_SIZE=huge/5273//consoleFull

build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos7/DIST/centos7/MACHINE_SIZE/huge/release/12.1.1-869-g08a6f41/rpm/el7/BUILD/ceph-12.1.1-869-g08a6f41/src/common/options.cc: In function 'void _Z41__static_initialization_and_destruction_0ii.constprop.1008()':
/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos7/DIST/centos7/MACHINE_SIZE/huge/release/12.1.1-869-g08a6f41/rpm/el7/BUILD/ceph-12.1.1-869-g08a6f41/src/common/options.cc:5673:57: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 const std::vector<Option> ceph_options = build_options();
                                                         ^
@gregsfortytwo

lgtm

@gregsfortytwo gregsfortytwo merged commit b16b973 into ceph:master Jul 31, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-cmake-disable-vta branch Aug 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment