Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/mon/mds: fix `config set` tell command #16700

Merged
merged 1 commit into from Aug 1, 2017

Conversation

Projects
None yet
3 participants
@jcsp
Copy link
Contributor

jcsp commented Jul 31, 2017

This was working for setting values, but failing to call
the config observers, so some values didn't take effect.

Fixes: http://tracker.ceph.com/issues/20803
Signed-off-by: John Spray john.spray@redhat.com

John Spray
osd/mon/mds: fix `config set` tell command
This was working for setting values, but failing to call
the config observers, so some values didn't take effect.

Fixes: http://tracker.ceph.com/issues/20803
Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp added the core label Jul 31, 2017

@jcsp jcsp requested a review from liewegas Jul 31, 2017

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Jul 31, 2017

see also #16685, lgtm either way.

@jcsp

This comment has been minimized.

Copy link
Contributor Author

jcsp commented Aug 1, 2017

retest this please

@liewegas liewegas closed this Aug 1, 2017

@liewegas liewegas reopened this Aug 1, 2017

@liewegas liewegas merged commit 3e21fd6 into ceph:master Aug 1, 2017

0 of 4 checks passed

Signed-off-by checking if commits are signed
Details
Unmodified Submodules checking if PR has modified submodules
Details
make check running make check
Details
make check (arm64) Build triggered. sha1 is merged.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.