New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rgw: Do not decrement stats cache when the cache values are zero #16720

Merged
merged 2 commits into from Sep 7, 2017

Conversation

Projects
None yet
4 participants
@prallabh

This comment has been minimized.

Show comment
Hide comment
@prallabh

prallabh Aug 1, 2017

Contributor

@oritwas can you please help review.
@smithfarm I've back ported this to Jewel by cherry picking from the master PR. Wanted this to be in the next release of Jewel pretty badly, thanks!

Contributor

prallabh commented Aug 1, 2017

@oritwas can you please help review.
@smithfarm I've back ported this to Jewel by cherry picking from the master PR. Wanted this to be in the next release of Jewel pretty badly, thanks!

@smithfarm smithfarm added this to the jewel milestone Aug 1, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 1, 2017

Contributor

@prallabh Looks good, will include it in the next jewel integration branch.

Contributor

smithfarm commented Aug 1, 2017

@prallabh Looks good, will include it in the next jewel integration branch.

@oritwas

oritwas approved these changes Aug 1, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 27, 2017

Contributor

@prallabh Could you please cherry-pick 634215e into this PR? (Ping me if/when you do so, and I'll add http://tracker.ceph.com/issues/21136 to the PR description.)

Contributor

smithfarm commented Aug 27, 2017

@prallabh Could you please cherry-pick 634215e into this PR? (Ping me if/when you do so, and I'll add http://tracker.ceph.com/issues/21136 to the PR description.)

prallabh and others added some commits Jul 18, 2017

rgw: Do not decrement stats cache when the cache values are zero
With RGWs configured in a load balancer, there is a possibility of
having the cached values going unbound, when PUT/DELETE operations
do not land up on the same RGW. To avoid such cases, make sure the
decrement of stats happen only when the cached values are sane.

Fixes: http://tracker.ceph.com/issues/20661
Signed-off-by: Pavan Rallabhandi <PRallabhandi@walmartlabs.com>
(cherry picked from commit 3903e21)

Conflicts:
	src/rgw/rgw_quota.cc
rgw: Prevent overflow of stats cached values
Signed-off-by: Pavan Rallabhandi <PRallabhandi@walmartlabs.com>
Fixes: http://tracker.ceph.com/issues/20934
Signed-off-by: Aleksei Gutikov <aleksey.gutikov@synesis.ru>
(cherry picked from commit 634215e)

Conflicts:
	src/rgw/rgw_quota.cc
		       Have the quota stats structures to reflect rounded values in KB and honor the signed integer values
@prallabh

This comment has been minimized.

Show comment
Hide comment
@prallabh

prallabh Aug 28, 2017

Contributor

@smithfarm Have done so, updated the description, rebased as well.

Contributor

prallabh commented Aug 28, 2017

@smithfarm Have done so, updated the description, rebased as well.

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 28, 2017

Contributor

Thanks!

Contributor

smithfarm commented Aug 28, 2017

Thanks!

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Sep 7, 2017

Contributor

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-53

Contributor

smithfarm commented Sep 7, 2017

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-53

@smithfarm smithfarm merged commit 7bdbd07 into ceph:jewel Sep 7, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment