New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/suites: escape the parenthesis of the whitelist text #16722

Merged
merged 3 commits into from Aug 2, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented Aug 1, 2017

if [ -f $(dirname $0)/../../standalone/ceph-helpers-root.sh ]; then
source $(dirname $0)/../../standalone/ceph-helpers-root.sh
if [ -f $(dirname $0)/../../standalone/ceph-helpers.sh ]; then
source $(dirname $0)/../../standalone/ceph-helpers.sh

This comment has been minimized.

@liewegas

liewegas Aug 1, 2017

Member

shouldn't this switch back to ../../workunits/ceph-helpers-root.sh? (I'm guessing the -root version is different?)

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Aug 1, 2017

@liewegas fixed and repushed.

if [ -f $(dirname $0)/../../standalone/ceph-helpers-root.sh ]; then
source $(dirname $0)/../../standalone/ceph-helpers-root.sh
if [ -f $(dirname $0)/../ceph-helpers.sh ]; then
source $(dirname $0)/../ceph-helpers.sh

This comment has been minimized.

@liewegas

liewegas Aug 1, 2017

Member

with -root too right?

This comment has been minimized.

@tchaikov

tchaikov Aug 1, 2017

Contributor

ahh, right! forgot to update the filename!

fixed and pushed again.

tchaikov added some commits Aug 1, 2017

qa/suites: escape the parenthesis of the whitelist text
so we can avoid the warnings like

grep: Unmatched ( or \(

because we pass the whitelisted string to `egrep -v "$1"` directly.

Signed-off-by: Kefu Chai <kchai@redhat.com>
qa/workunits/ceph-disk: fix the path to ceph-helpers-root.sh
partially reverts 841f3bd

Signed-off-by: Kefu Chai <kchai@redhat.com>
qa/suites: more whitelisting
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov merged commit 1ff1f83 into ceph:master Aug 2, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-qa-fixes branch Aug 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment