New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw_crypt: log error messages during failures #16726

Merged
merged 1 commit into from Aug 7, 2017

Conversation

Projects
None yet
5 participants
@theanalyst
Member

theanalyst commented Aug 1, 2017

Signed-off-by: Abhishek Lekshmanan abhishek@suse.com

@theanalyst theanalyst requested review from cbodley and aclamk Aug 1, 2017

@joscollin joscollin added the rgw label Aug 2, 2017

@joscollin

Looks good to me, except a nit:

Insecure, Invalid to make a consistent format.

@joscollin joscollin added the cleanup label Aug 2, 2017

@@ -1022,15 +1022,20 @@ int rgw_s3_prepare_encrypt(struct req_state* s,
get_crypt_attribute(s->info.env, parts, X_AMZ_SERVER_SIDE_ENCRYPTION_CUSTOMER_ALGORITHM);
if (! req_sse_ca.empty()) {
if (req_sse_ca != "AES256") {
ldout(s->cct, 5) << "ERROR: Invalid value for header"
<< "x-amz-server-side-encryption-customer-algorithm"

This comment has been minimized.

@cbodley

cbodley Aug 2, 2017

Contributor

missing space between header and x-amz

This comment has been minimized.

@theanalyst

theanalyst Aug 2, 2017

Member

ack, just had a line break to fill column < 80, will fix

@@ -1022,15 +1022,20 @@ int rgw_s3_prepare_encrypt(struct req_state* s,
get_crypt_attribute(s->info.env, parts, X_AMZ_SERVER_SIDE_ENCRYPTION_CUSTOMER_ALGORITHM);
if (! req_sse_ca.empty()) {
if (req_sse_ca != "AES256") {
ldout(s->cct, 5) << "ERROR: Invalid value for header"
<< "x-amz-server-side-encryption-customer-algorithm"

This comment has been minimized.

@aclamk

aclamk Aug 3, 2017

Contributor

@theanalyst I like the debug messages you introduced. I think encryption failures in L1170 L1180 L1194 should also be noted.

rgw_crypt: log error messages during failures
Adding log messages at debug level 5 indicating where we're failing
during PUT/GET requests for objects with encryption

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
@theanalyst

This comment has been minimized.

Member

theanalyst commented Aug 3, 2017

@aclamk @cbodley @joscollin thanks for the reveiw, updated.

@aclamk

aclamk approved these changes Aug 3, 2017

@theanalyst

This comment has been minimized.

Member

theanalyst commented Aug 3, 2017

jenkins test this please

@cbodley

cbodley approved these changes Aug 3, 2017

@cbodley cbodley added the needs-qa label Aug 3, 2017

@cbodley

This comment has been minimized.

Contributor

cbodley commented Aug 3, 2017

jenkins test this please

1 similar comment
@joscollin

This comment has been minimized.

Member

joscollin commented Aug 4, 2017

jenkins test this please

@yuriw yuriw merged commit 93a7ae8 into ceph:master Aug 7, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment