New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: Drop unused member variable reopen in C_OpenComplete #16729

Merged
merged 1 commit into from Aug 4, 2017

Conversation

Projects
None yet
4 participants
@amitkumar50
Contributor

amitkumar50 commented Aug 1, 2017

Fixes the Coverity Scan Report:

** CID 1402141 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member reopen is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com

@joscollin joscollin self-requested a review Aug 1, 2017

@joscollin

It looks like this is member is unused. librbd builds fine without it. Please verify the same and drop it.

@amitkumar50

This comment has been minimized.

Contributor

amitkumar50 commented Aug 2, 2017

@joscollin Thanks for comments.
I believe you mean delete the variable..

@joscollin

This comment has been minimized.

Member

joscollin commented Aug 2, 2017

@amitkumar50

This comment has been minimized.

Contributor

amitkumar50 commented Aug 2, 2017

@joscollin Done changes ..Thanks

@joscollin

This comment has been minimized.

Member

joscollin commented Aug 2, 2017

Jenkins retest this please

rbd: Uninitialized Non-static class member reopen
Fixed:

** CID 1402141 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member reopen is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com

@joscollin joscollin changed the title from rbd: Uninitialized Non-static class member reopen to rbd: Drop unused member variable reopen in C_OpenComplete Aug 2, 2017

@joscollin

This comment has been minimized.

Member

joscollin commented Aug 2, 2017

Jenkins retest this please

2 similar comments
@joscollin

This comment has been minimized.

Member

joscollin commented Aug 3, 2017

Jenkins retest this please

@amitkumar50

This comment has been minimized.

Contributor

amitkumar50 commented Aug 3, 2017

Jenkins retest this please

@dillaman

This comment has been minimized.

Contributor

dillaman commented Aug 3, 2017

retest this please

@amitkumar50

This comment has been minimized.

Contributor

amitkumar50 commented Aug 3, 2017

Jenkins retest this please

1 similar comment
@joscollin

This comment has been minimized.

Member

joscollin commented Aug 4, 2017

Jenkins retest this please

@dillaman

lgtm

@dillaman dillaman merged commit 7560c58 into ceph:master Aug 4, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment