Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: avoid statically allocating configuration options #16735

Merged
merged 2 commits into from Aug 2, 2017

Conversation

Projects
None yet
3 participants
@dillaman
Copy link
Contributor

dillaman commented Aug 1, 2017

No description provided.

dillaman added some commits Aug 1, 2017

rbd-fuse: remove dependency on ceph-common
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
common: avoid statically allocating configuration options
This was resulting in seg faults within rbd-fuse during shutdown. This also
fixes the "variable tracking size limit exceeded with -fvar-tracking-assignments,
retrying without" compiler warning".

Fixes: http://tracker.ceph.com/issues/20869
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

@dillaman dillaman added this to the luminous milestone Aug 1, 2017

@tchaikov tchaikov requested review from tchaikov and jcsp Aug 1, 2017

@jcsp

jcsp approved these changes Aug 1, 2017

@jcsp

This comment has been minimized.

Copy link
Contributor

jcsp commented Aug 1, 2017

So the issue was multiple attempted destructions because of the way we link and get the same symbol more than once, I guess? I worry that we would still have some issue there with destruction of the global ceph_options list though

@dillaman

This comment has been minimized.

Copy link
Contributor Author

dillaman commented Aug 1, 2017

@jcsp it was weird -- "rbd_options" was the only one being allocated on the heap it appeared (the rest were being allocated in the data section) and it was responsible for the seg fault when the static variable finalizers ran. It only happened if the process exited after forking but it wasn't being double-deleted.

@liewegas liewegas merged commit cae3a58 into ceph:master Aug 2, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@dillaman dillaman deleted the dillaman:wip-20869 branch Aug 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.