Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document bluestore compression settings #16747

Merged
merged 2 commits into from Aug 2, 2017

Conversation

Projects
None yet
4 participants
@tchaikov
Copy link
Contributor

tchaikov commented Aug 2, 2017

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov added this to the luminous milestone Aug 2, 2017

@tchaikov tchaikov requested a review from liewegas Aug 2, 2017

@tchaikov tchaikov force-pushed the tchaikov:wip-doc-fixes branch from 6f46081 to 41cf39d Aug 2, 2017

BlueStore supports inline compression using snappy, zlib, or LZ4. Please note,
the lz4 compression plugin is not distributed by the official release.

``bluestore compression algorithm``

This comment has been minimized.

Copy link
@xiexingguo

xiexingguo Aug 2, 2017

Member

bluestore_compression_algorithm?

This comment has been minimized.

Copy link
@tchaikov

tchaikov Aug 2, 2017

Author Contributor

will use spaces for consistency.

``bluestore compression algorithm``

:Description: The default compressor to use (if any) if the per-pool property
``compression_mode`` is not set. Note that zstd is *not*

This comment has been minimized.

Copy link
@xiexingguo

xiexingguo Aug 2, 2017

Member

This should be compression_algorithm instead.

==================

BlueStore supports inline compression using snappy, zlib, or LZ4. Please note,
the lz4 compression plugin is not distributed by the official release.

This comment has been minimized.

Copy link
@theanalyst

theanalyst Aug 2, 2017

Member

distributed in the official release?


:Description: The default compressor to use (if any) if the per-pool property
``compression_mode`` is not set. Note that zstd is *not*
recommended for blustore due to high CPU overhead when

This comment has been minimized.

Copy link
@theanalyst

theanalyst Aug 2, 2017

Member

bluestore

``bluestore_compression_mode``

:Description: The default policy for using compression if the per-pool property
``compressoin_mode`` is not set. ``none`` means never use

This comment has been minimized.

Copy link
@theanalyst

theanalyst Aug 2, 2017

Member

typo compression_mode


``bluestore_compression_min_blob_size``

:Description: Chunks smaller thank this are never compressed.

This comment has been minimized.

Copy link
@theanalyst

``bluestore_compression_min_blob_size``

:Description: Chunks smaller thank this are never compressed.

This comment has been minimized.

Copy link
@xiexingguo

xiexingguo Aug 2, 2017

Member

s/thank/than/

@tchaikov tchaikov force-pushed the tchaikov:wip-doc-fixes branch 2 times, most recently from 458c507 to f9c001c Aug 2, 2017

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

tchaikov commented Aug 2, 2017

@theanalyst @xiexingguo fixed and repushed.

doc/man/8/radosgw-admin: document --compression option
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov force-pushed the tchaikov:wip-doc-fixes branch from f9c001c to eec19f8 Aug 2, 2017

:Required: No
:Default: 0

``bluestore_compression_min_blob_size_hdd``

This comment has been minimized.

Copy link
@xiexingguo

xiexingguo Aug 2, 2017

Member

Keep pace with others, then?

This comment has been minimized.

Copy link
@tchaikov

tchaikov Aug 2, 2017

Author Contributor

should be addressed by the latest change.


``bluestore_compression_min_blob_size_hdd``

:Description: Default value of ``bluestore_compression_min_blob_size``

This comment has been minimized.

Copy link
@xiexingguo

xiexingguo Aug 2, 2017

Member

And here

doc: document bluestore compression settings
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov force-pushed the tchaikov:wip-doc-fixes branch from eec19f8 to f273712 Aug 2, 2017

@xiexingguo

This comment has been minimized.

Copy link
Member

xiexingguo commented Aug 2, 2017

looks good to me, a very small me as an ESL speaker:-)

@liewegas liewegas merged commit aadc5c1 into ceph:master Aug 2, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.