New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr: handle "module.set_config(.., None)" correctly #16749

Merged
merged 2 commits into from Aug 3, 2017

Conversation

Projects
None yet
4 participants
@tchaikov
Contributor

tchaikov commented Aug 2, 2017

No description provided.

tchaikov added some commits Aug 2, 2017

mgr: handle "module.set_config(.., None)" correctly
otherwise "ceph restful delete-key foo" would fail:

TypeError: ceph_config_set() argument 3 must be string, not None

Signed-off-by: Kefu Chai <kchai@redhat.com>
qa: refactor suites/rados/rest/mgr-restful
- use "ceph restful restart" to restart the restful API server instead
of restarting the ceph-mgr
- test "ceph restful delete-key"
- test "ceph restful list-keys"

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested review from liewegas and jcsp Aug 2, 2017

@tchaikov tchaikov added this to the luminous milestone Aug 2, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Aug 2, 2017

@nrdmn could you please help review this PR?

@nrdmn

This comment has been minimized.

Contributor

nrdmn commented Aug 2, 2017

@tchaikov sure I can do that this evening

@jcsp

jcsp approved these changes Aug 2, 2017

@nrdmn

nrdmn approved these changes Aug 2, 2017

@liewegas liewegas merged commit 342607f into ceph:master Aug 3, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment