New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: wait for maps before doing 'ceph tell ... help' #16756

Merged
merged 1 commit into from Aug 3, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Member

liewegas commented Aug 2, 2017

If we don't have a mgrmap yet (usually we do, but it's racy) MgrClient
will assume EACCES if we try to send a command. This can lead to
EACCES from 'ceph tell mgr help'.

The mon sends maps in alphanumeric order, so waiting for osdmap will
include mgrmap and fsmap. That's everything (current) except servicemap,
but we can't 'tell' those anyway.

Fixes: http://tracker.ceph.com/issues/20113
Signed-off-by: Sage Weil sage@redhat.com

ceph: wait for maps before doing 'ceph tell ... help'
If we don't have a mgrmap yet (usually we do, but it's racy) MgrClient
will assume EACCES if we try to send a command.  This can lead to
EACCES from 'ceph tell mgr help'.

The mon sends maps in alphanumeric order, so waiting for osdmap will
include mgrmap and fsmap.  That's everything (current) except servicemap,
but we can't 'tell' those anyway.

Fixes: http://tracker.ceph.com/issues/20113
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas added this to the luminous milestone Aug 2, 2017

@liewegas liewegas requested a review from tchaikov Aug 2, 2017

@@ -355,6 +355,9 @@ def do_extended_help(parser, args, target, partial):
partial=partial))
def help_for_target(target, partial=None):
# wait for osdmap because we know this is sent after the mgrmap
# and monmap (it's alphabetical).
cluster_handle.wait_for_latest_osdmap()

This comment has been minimized.

@tchaikov

tchaikov Aug 3, 2017

Contributor

yes, the issue also applies when target is osd or mon.

@liewegas liewegas merged commit af145dd into ceph:master Aug 3, 2017

3 of 4 checks passed

make check (arm64) make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-20113 branch Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment