New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rgw : fix race in RGWCompleteMultipart #16767

Merged
merged 1 commit into from Sep 12, 2017

Conversation

Projects
None yet
5 participants
@mattbenjamin
Contributor

mattbenjamin commented Aug 2, 2017

@mattbenjamin mattbenjamin added this to the jewel milestone Aug 2, 2017

@mattbenjamin mattbenjamin changed the base branch from master to jewel-next Aug 2, 2017

@mattbenjamin mattbenjamin changed the base branch from jewel-next to jewel Aug 2, 2017

@mattbenjamin mattbenjamin changed the title from jewel: rgw : fix race in RGWCompleteMultipart to [DNM]: jewel: rgw : fix race in RGWCompleteMultipart Aug 2, 2017

@mattbenjamin

This comment has been minimized.

Show comment
Hide comment
@mattbenjamin

mattbenjamin Aug 4, 2017

Contributor

(this failed in teuthology rgw suite, reproduced by hand, working it)

Contributor

mattbenjamin commented Aug 4, 2017

(this failed in teuthology rgw suite, reproduced by hand, working it)

@mattbenjamin mattbenjamin requested a review from oritwas Aug 8, 2017

@mattbenjamin mattbenjamin self-assigned this Aug 8, 2017

@mattbenjamin

This comment has been minimized.

Show comment
Hide comment
@mattbenjamin

mattbenjamin Aug 8, 2017

Contributor

@Orit this is not much more inelegant than the change on master, which also did this inline in CompleteMultipart; we should refactor upstream, but just need Jewel to be correct

Contributor

mattbenjamin commented Aug 8, 2017

@Orit this is not much more inelegant than the change on master, which also did this inline in CompleteMultipart; we should refactor upstream, but just need Jewel to be correct

@mattbenjamin mattbenjamin changed the title from [DNM]: jewel: rgw : fix race in RGWCompleteMultipart to jewel: rgw : fix race in RGWCompleteMultipart Aug 8, 2017

Show outdated Hide outdated src/rgw/rgw_op.cc
Show outdated Hide outdated src/rgw/rgw_op.cc
rgw : fix race in RGWCompleteMultipart
Fixes : http://tracker.ceph.com/issues/20861

Signed-off-by: Abhishek Varshney <abhishek.varshney@flipkart.com>
(cherry picked from commit dd7dc62)
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Sep 7, 2017

Contributor

@oritwas This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-53 and @mattbenjamin re-pushed. Can you take another look?

@mattbenjamin Can you include a "Conflicts" section at the end of the commit message?

Contributor

smithfarm commented Sep 7, 2017

@oritwas This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-53 and @mattbenjamin re-pushed. Can you take another look?

@mattbenjamin Can you include a "Conflicts" section at the end of the commit message?

@smithfarm smithfarm changed the title from jewel: rgw : fix race in RGWCompleteMultipart to [DNM] jewel: rgw : fix race in RGWCompleteMultipart Sep 12, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Sep 12, 2017

Contributor

@oritwas Have your concerns been addressed now?

Contributor

smithfarm commented Sep 12, 2017

@oritwas Have your concerns been addressed now?

@smithfarm smithfarm changed the title from [DNM] jewel: rgw : fix race in RGWCompleteMultipart to jewel: rgw : fix race in RGWCompleteMultipart Sep 12, 2017

@smithfarm smithfarm merged commit 37dec02 into ceph:jewel Sep 12, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Sep 12, 2017

Contributor

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-63

Contributor

smithfarm commented Sep 12, 2017

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment