New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: should not restrict location_constraint same when user not provide #16770

Merged
merged 1 commit into from Aug 7, 2017

Conversation

Projects
None yet
4 participants
@tianshan
Contributor

tianshan commented Aug 3, 2017

Signed-off-by: Tianshan Qu tianshan@xsky.com

rgw: should not restrict location_constraint same when user not provide
Signed-off-by: Tianshan Qu <tianshan@xsky.com>
@tianshan

This comment has been minimized.

Contributor

tianshan commented Aug 3, 2017

@cbodley I think if user not privode location_constraint to create bucket in seoncd zonegroup, we should just pass, is there any other concern?

@joscollin

Why ? Any justification ? The error message makes sense, when the location_constraint is empty. Maybe, we can check if it is empty separately.

@tianshan

This comment has been minimized.

Contributor

tianshan commented Aug 3, 2017

@joscollin from first thought, client may not know which one is master zonegroup, so if client create bucket without location_constraint, master zonegroup will create success but second
zonegroup will blocked by this check.

@cbodley

cbodley approved these changes Aug 3, 2017

@yuriw yuriw merged commit 1c63af1 into ceph:master Aug 7, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@tianshan tianshan deleted the tianshan:fix_create_bucket branch Aug 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment