Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libradosstriper: Initialize member variable m_writeRc in WriteCompletionData #16780

Merged
merged 1 commit into from Aug 6, 2017

Conversation

Projects
None yet
2 participants
@amitkumar50
Copy link
Contributor

amitkumar50 commented Aug 3, 2017

Fixes the Coverity Scan Report:

** 1414521 Uninitialized scalar field
CID 1414521 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
3. uninit_member: Non-static class member m_writeRc is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com

@amitkumar50

This comment has been minimized.

Copy link
Contributor Author

amitkumar50 commented Aug 3, 2017

Jenkins retest this please

rado: Initilizating uninitilized member m_writeRc
Fixes the Coverity Scan Report:

** 1414521 Uninitialized scalar field
CID 1414521 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
3. uninit_member: Non-static class member m_writeRc is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com
@joscollin
Copy link
Member

joscollin left a comment

What is rado module prefix in Commit Title and PR title. Please fix it.

@amitkumar50 amitkumar50 changed the title rado: Initilizating uninitilized member m_writeRc rados: Initilizating uninitilized member m_writeRc Aug 6, 2017

@amitkumar50

This comment has been minimized.

Copy link
Contributor Author

amitkumar50 commented Aug 6, 2017

@joscollin Thanks for comments. Changed to rados.

@amitkumar50

This comment has been minimized.

Copy link
Contributor Author

amitkumar50 commented Aug 6, 2017

Jenkins retest this please

2 similar comments
@joscollin

This comment has been minimized.

Copy link
Member

joscollin commented Aug 6, 2017

Jenkins retest this please

@joscollin

This comment has been minimized.

Copy link
Member

joscollin commented Aug 6, 2017

Jenkins retest this please

@joscollin joscollin changed the title rados: Initilizating uninitilized member m_writeRc libradosstriper: Initialize member variable m_writeRc in WriteCompletionData Aug 6, 2017

@joscollin
Copy link
Member

joscollin left a comment

LGTM

@joscollin joscollin merged commit f1b1e94 into ceph:master Aug 6, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
@joscollin

This comment has been minimized.

Copy link
Member

joscollin commented Aug 7, 2017

@amitkumar50
The tests shows following warning, which is related to this PR it seems. Please check.

/home/jcollin/ceph/src/libradosstriper/RadosStriperImpl.cc: In constructor ‘{anonymous}::WriteCompletionData::WriteCompletionData(libradosstriper::RadosStriperImpl*, const string&, const string&, librados::AioCompletionImpl*, int)’:
/home/jcollin/ceph/src/libradosstriper/RadosStriperImpl.cc:253:28: warning: ‘{anonymous}::WriteCompletionData::m_unlockCompletion’ will be initialized after [-Wreorder]
   librados::AioCompletion *m_unlockCompletion;
                            ^
/home/jcollin/ceph/src/libradosstriper/RadosStriperImpl.cc:251:7: warning:   ‘int {anonymous}::WriteCompletionData::m_writeRc’ [-Wreorder]
   int m_writeRc;
       ^
/home/jcollin/ceph/src/libradosstriper/RadosStriperImpl.cc:270:1: warning:   when initialized here [-Wreorder]
 WriteCompletionData::WriteCompletionData

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.