New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg: Initialize member variables in Infiniband #16781

Merged
merged 1 commit into from Aug 6, 2017

Conversation

Projects
None yet
2 participants
@amitkumar50
Contributor

amitkumar50 commented Aug 3, 2017

Fixes:

1414516 Uninitialized pointer field
2. uninit_member: Non-static class member max_send_wr is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member max_recv_wr is not initialized in this constructor nor in any functions that it calls.
6. uninit_member: Non-static class member max_sge is not initialized in this constructor nor in any functions that it calls.
8. uninit_member: Non-static class member ib_physical_port is not initialized in this constructor nor in any functions that it calls.
10. uninit_member: Non-static class member memory_manager is not initialized in this constructor nor in any functions that it calls.
12. uninit_member: Non-static class member srq is not initialized in this constructor nor in any functions that it calls.
14. uninit_member: Non-static class member device is not initialized in this constructor nor in any functions that it calls.

CID 1414516 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
16. uninit_member: Non-static class member pd is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com

@amitkumar50

This comment has been minimized.

Contributor

amitkumar50 commented Aug 3, 2017

Jenkins retest this please

MemoryManager* memory_manager = nullptr;
ibv_srq* srq = nullptr; // shared receive work queue
Device *device = nullptr;
ProtectionDomain *pd = nullptr;
DeviceList *device_list = nullptr;

This comment has been minimized.

@joscollin

joscollin Aug 5, 2017

Member

device and pd are compared to NULL. So check each pointers what it is compared to, to fix it appropriately.

@amitkumar50

This comment has been minimized.

Contributor

amitkumar50 commented Aug 5, 2017

@joscollin Thanks for Comments. Done Changes.

@joscollin

This comment has been minimized.

Member

joscollin commented Aug 5, 2017

Jenkins retest this please

msg: Initilization of uninitialized class Infiniband members
Fixes coverity issues:

1414516 Uninitialized pointer field
2. uninit_member: Non-static class member max_send_wr is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member max_recv_wr is not initialized in this constructor nor in any functions that it calls.
6. uninit_member: Non-static class member max_sge is not initialized in this constructor nor in any functions that it calls.
8. uninit_member: Non-static class member ib_physical_port is not initialized in this constructor nor in any functions that it calls.
10. uninit_member: Non-static class member memory_manager is not initialized in this constructor nor in any functions that it calls.
12. uninit_member: Non-static class member srq is not initialized in this constructor nor in any functions that it calls.
14. uninit_member: Non-static class member device is not initialized in this constructor nor in any functions that it calls.
CID 1414516 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
16. uninit_member: Non-static class member pd is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com
@joscollin

This comment has been minimized.

Member

joscollin commented Aug 6, 2017

Jenkins retest this please

@joscollin joscollin changed the title from msg: Initilization of uninitialized class Infiniband members to msg: Initilize member variables in Infiniband Aug 6, 2017

@joscollin joscollin changed the title from msg: Initilize member variables in Infiniband to msg: Initialize member variables in Infiniband Aug 6, 2017

@joscollin joscollin merged commit fd974ff into ceph:master Aug 6, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment