test: Initialize pointer variables in TestMemIoCtxImpl #16785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joscollin
requested changes
Aug 4, 2017
| TestMemRadosClient *m_client; | ||
| TestMemCluster::Pool *m_pool; | ||
| TestMemRadosClient *m_client = NULL; | ||
| TestMemCluster::Pool *m_pool = NULL; | ||
|
|
There was a problem hiding this comment.
I don't find an existing comparison with NULL in the implementation. So better change it to nullptr (introduce now).
amitkumar50
force-pushed
the
cov-1274326
branch
from
48fecf5
to
6078f69
Compare
|
@joscollin Thanks for Comments. Done Changes. |
joscollin
changed the title
Fixes the coverity issue: 1274326 Uninitialized pointer field 2. uninit_member: Non-static class member m_client is not initialized in this constructor nor in any functions that it calls. CID 1274326 (ceph#1 of 1): Uninitialized pointer field (UNINIT_CTOR) 4. uninit_member: Non-static class member m_pool is not initialized in this constructor nor in any functions that it calls. Signed-off-by: Amit Kumar amitkuma@redhat.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Signed-off-by: Amit Kumar amitkuma@redhat.com