New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/buffer: off-by-one error in max iov length blocking #16803

Merged
merged 1 commit into from Aug 4, 2017

Conversation

Projects
None yet
2 participants
@dmick
Member

dmick commented Aug 4, 2017

The loop in write_fd stops at IOV_MAX-1; it could go to IOV_MAX
and write in more-natural sizes without extra tail writes.

Fixes: http://tracker.ceph.com/issues/20907
Signed-off-by: Dan Mick dan.mick@redhat.com

common/buffer: off-by-one error in max iov length blocking
The loop in write_fd stops at IOV_MAX-1; it could go to IOV_MAX
and write in more-natural sizes without extra tail writes.

Fixes: http://tracker.ceph.com/issues/20907
Signed-off-by: Dan Mick <dan.mick@redhat.com>
@dmick

This comment has been minimized.

Member

dmick commented Aug 4, 2017

I ran unittest_bufferlist manually, and also ran just BufferList.write_fd and observed the expected writev() vector sizes.

@gregsfortytwo

lgtm

@gregsfortytwo gregsfortytwo merged commit 62a2e42 into ceph:master Aug 4, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment