New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messages: Initialize member variables #16839

Merged
merged 1 commit into from Aug 5, 2017

Conversation

Projects
None yet
2 participants
@amitkumar50
Contributor

amitkumar50 commented Aug 5, 2017

Fixes the coverity Issues:

** 1019615 Uninitialized scalar field

  1. uninit_member: Non-static class member service_type is not initialized
    in this constructor nor in any functions that it calls.
    CID 1019615 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
  2. uninit_member: Non-static class member service_op is not initialized
    in this constructor nor in any functions that it calls.

** 1019618 Uninitialized scalar field

  1. uninit_member: Non-static class member op is not initialized in this
    constructor nor in any functions that it calls.
  2. uninit_member: Non-static class member cookie is not initialized in
    this constructor nor in any functions that it calls.
    CID 1019618 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
  3. uninit_member: Non-static class member last_committed is not initialized
    in this constructor nor in any functions that it calls.

** 1019620 Uninitialized scalar field

  1. uninit_member: Non-static class member epoch is not initialized in this
    constructor nor in any functions that it calls.
    CID 1019620 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
  2. uninit_member: Non-static class member request_ack is not initialized
    in this constructor nor in any functions that it calls.

** 1019621 Uninitialized scalar field

  1. uninit_member: Non-static class member epoch is not initialized in this
    constructor nor in any functions that it calls.
    CID 1019621 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
  2. uninit_member: Non-static class member round is not initialized in this
    constructor nor in any functions that it calls

Signed-off-by: Amit Kumar amitkuma@redhat.com

@joscollin joscollin self-requested a review Aug 5, 2017

@joscollin

LGTM

@joscollin joscollin changed the title from messages: Initializing variables various classes to messages: Initialize member variables Aug 5, 2017

@joscollin joscollin merged commit ad5b561 into ceph:master Aug 5, 2017

3 of 4 checks passed

make check (arm64) make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
messages: Initializing variables various classes
Fixes the coverity Issues:

** 1019615 Uninitialized scalar field
2. uninit_member: Non-static class member service_type is not initialized
 in this constructor nor in any functions that it calls.
CID 1019615 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member service_op is not initialized
 in this constructor nor in any functions that it calls.

** 1019618 Uninitialized scalar field
2. uninit_member: Non-static class member op is not initialized in this
 constructor nor in any functions that it calls.
4. uninit_member: Non-static class member cookie is not initialized in
 this constructor nor in any functions that it calls.
CID 1019618 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
6. uninit_member: Non-static class member last_committed is not initialized
 in this constructor nor in any functions that it calls.

** 1019620 Uninitialized scalar field
2. uninit_member: Non-static class member epoch is not initialized in this
 constructor nor in any functions that it calls.
CID 1019620 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member request_ack is not initialized
in this constructor nor in any functions that it calls.

** 1019621 Uninitialized scalar field
2. uninit_member: Non-static class member epoch is not initialized in this
constructor nor in any functions that it calls.
CID 1019621 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member round is not initialized in this
constructor nor in any functions that it calls

Signed-off-by: Amit Kumar amitkuma@redhat.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment