Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: rbd-mirror: simplify notifications for image assignment #16878

Merged
merged 14 commits into from Aug 7, 2017

Conversation

Projects
None yet
1 participant
@dillaman
Copy link
Contributor

dillaman commented Aug 7, 2017

No description provided.

dillaman added some commits Jul 19, 2017

rbd-mirror: helper state machine for retrieving image id from global id
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: image replayer should query remote mirror uuid / image id
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: clean up bootstrap recovery from missing local image
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: pre-register image id before creating image
This fixes a potential race condition that could occur previously
if rbd-mirror daemon failed between creating an image and recording
the image id to the remote journal.

Fixes: http://tracker.ceph.com/issues/15764
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: simplify resync handling within image replayer
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: new 'peer image removed' notification to instance watchers
Note: this commit intentionally breaks backwards compatibility with
Luminous RC instance watcher notifications.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: simplified acquire/release notification messages
The other instances should already know about the possible peers, so
we can co-opt these messages for use by the policy mapper.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: co-opt image acquire/release notifications
This notifications will now be used by the policy when a (re)map is
required.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: helper state machine for querying remote peer uuid / imag…
…e id

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: restore deletion propagation and image replayer cleanup
The previous intermediate commits removed handling for deletion
propagation and image replayer cleanup since this logic has been
moved from instance to image replayer. Note that eventually the
policy's release notification will be responsible for the cleanup
of image replayers.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: ensure threads are mockable for testing
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: moved wait for deletion logic within image replayer
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: avoid silently failing to register image replayer admin s…
…ockets

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: clean up logging during test shut down
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

@dillaman dillaman added this to the luminous milestone Aug 7, 2017

@dillaman dillaman merged commit 9a4953f into ceph:luminous Aug 7, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@dillaman dillaman deleted the dillaman:wip-rbd-mirror-image-ids-luminous branch Aug 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.