New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: rbd-ggate: tool to map images on FreeBSD via GEOM Gate #16895

Merged
merged 2 commits into from Aug 8, 2017

Conversation

Projects
None yet
2 participants
@dillaman
Contributor

dillaman commented Aug 8, 2017

No description provided.

Mykola Golub added some commits May 14, 2017

rbd-ggate: tool to map images on FreeBSD via GEOM Gate
rbd-ggate spawns a process responsible for the creation of ggate
device and forwarding I/O requests between the GEOM Gate kernel
subsystem and RADOS.

On FreeBSD it provides functionality similar to rbd-nbd on Linux.

Signed-off-by: Mykola Golub <mgolub@mirantis.com>
test: add wrapper to run rbd-ggate test on FreeBSD
Signed-off-by: Mykola Golub <mgolub@mirantis.com>

@dillaman dillaman added this to the luminous milestone Aug 8, 2017

@dillaman dillaman merged commit 312ec1a into ceph:luminous Aug 8, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@dillaman dillaman deleted the dillaman:wip-15339-luminous branch Aug 8, 2017

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Aug 8, 2017

@dillaman
Arrgh, just missed this. the rights on:

./src/test/rbd-ggate.sh
./qa/workunits/rbd/rbd-ggate.sh

Both need to be 755, and at least one has 664, so the test fails.
Not major, since it is for testing, but a good start would be better.

@dillaman

This comment has been minimized.

Contributor

dillaman commented Aug 8, 2017

@wjwithagen Can you open a new PR for the issue?

@dillaman

This comment has been minimized.

Contributor

dillaman commented Aug 8, 2017

... both files have 0775 permissions on my master and luminous branch

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Aug 8, 2017

@dillaman
Right, I checkout master to be 100% sure, but they land just fine with correct rights,
So we're oke there.
Sorry for the noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment