New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rgw: radosgw-admin: fix bucket limit check argparse, div(0) #16952

Merged
merged 1 commit into from Sep 7, 2017

Conversation

Projects
None yet
3 participants
@robbat2
Contributor

robbat2 commented Aug 9, 2017

rgw-admin: fix bucket limit check argparse, div(0)
1. normalize arg parsing for "bucket limit check"
1.1 s/buckets/bucket/

2. avoid dividing by num_shards when it is 0

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit fb8e2fa)
Fixes: http://tracker.ceph.com/issues/20966
@mattbenjamin

This comment has been minimized.

Show comment
Hide comment
@mattbenjamin

mattbenjamin Aug 9, 2017

Contributor

@robbat2 oh, is this a backport?

Contributor

mattbenjamin commented Aug 9, 2017

@robbat2 oh, is this a backport?

@robbat2

This comment has been minimized.

Show comment
Hide comment
@robbat2

robbat2 Aug 9, 2017

Contributor

yes, it was missed in the other backport of bucket limit check

Contributor

robbat2 commented Aug 9, 2017

yes, it was missed in the other backport of bucket limit check

@mattbenjamin

lgtm

@smithfarm smithfarm added this to the jewel milestone Aug 9, 2017

@smithfarm smithfarm changed the title from rgw-admin: fix bucket limit check argparse, div(0) to jewel: rgw: rgw-admin: fix bucket limit check argparse, div(0) Aug 9, 2017

@smithfarm smithfarm changed the title from jewel: rgw: rgw-admin: fix bucket limit check argparse, div(0) to jewel: rgw: radosgw-admin: fix bucket limit check argparse, div(0) Aug 9, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Sep 7, 2017

Contributor

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-53

Contributor

smithfarm commented Sep 7, 2017

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-53

@smithfarm smithfarm merged commit d4797bf into ceph:jewel Sep 7, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment