New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: "ceph-volume: adds functional CI testing #16919" #16970

Merged
merged 15 commits into from Aug 10, 2017

Conversation

Projects
None yet
3 participants
@andrewschoen
Contributor

andrewschoen commented Aug 10, 2017

backport of #16919

andrewschoen and others added some commits Aug 4, 2017

ceph-volume: adds a functional testing scenario for lvm create
This setups up the basic test harness and adds a test for the create
subcommand. The test uses ceph-ansible to deploy a cluster using
``ceph-volume lvm create``, tests the cluster state using the
ceph-ansible test suite, reboots the nodes and then tests again.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 750d9f4)
ceph-volume: tox define vagrant cwd
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 89ccbd8)
ceph-volume: setup nodes for testinfra testing
This uses the playbook that exists in ceph-ansible to prepare the nodes for
testing by installing net-tools.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 97b216f)
ceph-volume: vagrantfile runs storagectl once
It assumes that if there is a disk left it has already run. This avoids
issues when reloading/restarting machines with vagrant.

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 476d1f5)
ceph-volume: create a centos7 factor for functional testing
We want to run these tests on multiple distros so this change sets the
foundation for that.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit c8e3be6)
ceph-volume: adds the xenial distro factor
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 1b42754)
ceph-volume: add placeholders for prepare_activate testing in tox.ini
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 852a947)
ceph-volume: adds CEPH_VOLUME_DEBUG=1 to functional tests
This will show us tracebacks if ceph-volume fails

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 5a90f4c)
ceph-volume: remove unused config from vagrant_variables.yml files
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 855ce63)
ceph-volume: lvm activate should not ignore exit status codes
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit c866123)
ceph-volume util add a helper to check if a device is mounted
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit d77d86a)
ceph-volume: lvm activate should check if the device is mounted to pr…
…event errors from mount

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit c61aea4)

@andrewschoen andrewschoen requested a review from alfredodeza Aug 10, 2017

alfredodeza added some commits Aug 9, 2017

ceph-volume: tests add tests for the is_mounted utility
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit dd4db2f)
ceph-volume: create a utf-8 string decoder for py3 compat
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit b50f1fb)
ceph-volume: is_mounted should use a bytes->string util to compare st…
…rings

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 4bb4c43)
@andrewschoen

This comment has been minimized.

Contributor

andrewschoen commented Aug 10, 2017

Now this also includes commits from #16962

@alfredodeza

This comment has been minimized.

Contributor

alfredodeza commented Aug 10, 2017

jenkins test ceph-volume tox

@alfredodeza alfredodeza merged commit ba364e9 into luminous Aug 10, 2017

3 of 4 checks passed

make check running make check
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume tox testing ceph-volume tox OK
Details

@alfredodeza alfredodeza deleted the backport-16919 branch Aug 10, 2017

@ktdreyer

This comment has been minimized.

Member

ktdreyer commented Aug 10, 2017

It would be great to get this in before v12.2.0 is tagged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment