New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: tests: qa/standalone: misc fixes #16985

Merged
merged 20 commits into from Aug 24, 2017

Conversation

@dzafman
Member

dzafman commented Aug 11, 2017

Backport: http://tracker.ceph.com/issues/20979
including #17026
including #17093
including #17098

dzafman added some commits Jul 28, 2017

qa: Dump logs after daemons are killed to make sure everything is flu…
…shed

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 4314cdd)
qa: run-standalone.sh improvements
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 8c76805)
qa: Add special test_failure.sh script (not run by default)
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit b20dfc2)
qa: Add create_pool() which sleeps 1 second like python variant
wait_for_clean() can miss the new pool if it races with pool create.

Fixes: http://tracker.ceph.com/issues/20465

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 99ad4bb)
qa: Skip ceph-helpers.sh which is tested through test-ceph-helpers.sh
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit d99f2a7)
qa: ceph-helpers.sh fixes
Add missing teardown to cleanup test directory
Fix pgid due to elimination of initial default pool
Testing could never fail because run_tests return ignored

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 6941361)
qa: Add support for specifying sub-tests with run-standalone.sh
Fix test-ceph-helpers.sh to pass additional arguments on

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 2a679a3)
qa: Add common generalized inject_eio() to ceph-helpers.sh
Retry for a while to allow pool to appear

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 574b3cd)
qa: osd-scrub-repair.sh handle older versions of jq
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 3988eba)
qa: Raise mon-data-avail-warn to pass tests with less space
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 61bfd23)
qa: For FreeBSD skip osd-dup.sh because there is no bluestore
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 4db5124)
qa: Add support for core dumps
Save core dumps when running tests locally
Dump logs to output whenever cores seen

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 229de6b)
osd: Fix Paxos shutdown handling for commit_finish race
Fixes: http://tracker.ceph.com/issues/20921

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit c140457)
osd: Avoid confusion over legacy snaps when head_exists corrupt
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 1fe6cb0)
qa: Testing of ceph-helpers.sh, teardown on fail to dump logs, save c…
…ores

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit dddda52)
qa: Fix races with waiting for scrubs
The trigger_scrub sets the last_scrub_stamp backwards to
force a scheduled scrub.  In a small window this stamp could get propagated
to the mgr.  A test failure occurred because wait_for_scrub() was confused
by seeing a backward moving date.

The most critical change is having wait_for_scrub() make sure that the
date advances past the previous in value.

A test failed because the random backoff kept delayed triggered scrub, so
set osd_scrub_backoff throughout.

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit ae2c533)
qa: Fix broken test_activate_osd() due to missing space
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit e24ac51)

@smithfarm smithfarm added this to the luminous milestone Aug 11, 2017

@smithfarm smithfarm changed the title from Luminous: qa/standalone: misc fixes to luminous: tests: qa/standalone: misc fixes Aug 11, 2017

@dzafman

This comment has been minimized.

Member

dzafman commented Aug 15, 2017

I want to add a cherry-pick of #17026 to this pull request.

dzafman added some commits Aug 15, 2017

tests: qa/standalone: Add trap for signals to resetore the kernel cor…
…e pattern

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 982aef7)
tests: run-standalone.sh improve error message
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 175b107)
sudo sysctl -w ${KERNCORE}=${precore}
fi
exit 0
}

This comment has been minimized.

@wjwithagen

wjwithagen Aug 19, 2017

Contributor

@dzafman
Exiting here with 0 will return OKE which is probably no the correct information once you run this in a testing environment.

tests: run-standalone.sh skip core_pattern if already set
If sudo requires a password it is nice to be able to avoid
sudo sysctl by setting core_pattern ahead of time.

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 599d762)
@theanalyst

This comment has been minimized.

Member

theanalyst commented Aug 22, 2017

@dzafman are the OSD related changes needed in this patchset itself, and does this need to go in for 12.2.0?

@dzafman

This comment has been minimized.

Member

dzafman commented Aug 22, 2017

@theanalyst The osd and test changes fix all run-standalone.sh tests to run without failure. They rarely fail in official runs of teuthology because a subset run won't run many of these tests. I wouldn't have a problem if you wanted to exclude it, but it is ready to go.

@dzafman dzafman assigned theanalyst and smithfarm and unassigned smithfarm Aug 23, 2017

@dzafman

This comment has been minimized.

Member

dzafman commented Aug 23, 2017

@liewegas You approved this, but do you want it in now or the next RC or point release?

@liewegas liewegas merged commit 4fbf379 into ceph:luminous Aug 24, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@dzafman dzafman deleted the dzafman:wip-standalone-luminous branch Sep 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment