Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd-mirror: Set the data pool correctly when creating images #17023

Merged
merged 2 commits into from Aug 17, 2017

Conversation

Projects
None yet
4 participants
@adamwg
Copy link
Contributor

adamwg commented Aug 14, 2017

Previously the data-pool option was ignored by rbd-mirror, so when using
erasure coding data for the image on the secondary site would end up in
the metadata pool.

Configure the data-pool using the data-pool's name from the primary site
when creating images on the secondary site.

Fixes: http://tracker.ceph.com/issues/20567

Signed-off-by: Adam Wolfe Gordon awg@digitalocean.com

rbd-mirror: Set the data pool correctly when creating images
Previously the data-pool option was ignored by rbd-mirror, so when using
erasure coding data for the image on the secondary site would end up in
the metadata pool.

Configure the data-pool using the data-pool's name from the primary site
when creating images on the secondary site.

Fixes: http://tracker.ceph.com/issues/20567

Signed-off-by: Adam Wolfe Gordon <awg@digitalocean.com>
@trociny

This comment has been minimized.

Copy link
Contributor

trociny commented Aug 15, 2017

The proposed fix looks good to me as a default behaviour. Still it would be nice if a user could change this. I can imagine a use case when one cluster has erasure coding pools for image data and another one does not.

@adamwg

This comment has been minimized.

Copy link
Contributor Author

adamwg commented Aug 15, 2017

@trociny Agreed. I'm planning to start work soon on allowing the data-pool to be specified when a peer is added. Of course, I won't be upset if someone beats me to it ;-).

@trociny
Copy link
Contributor

trociny left a comment

Tested with the test from #17062 and LGTM.

@dillaman what do you think?

@dillaman

This comment has been minimized.

Copy link
Contributor

dillaman commented Aug 17, 2017

As is, I think we need to update the mirroring documentation to state that now not only do the mirrored pools need to match across clusters, but also any data pools. Alternatively, you could add a new rbd_mirror_data_pools_enabled-like configuration option.

doc: Update mirroring docs to mention data-pool configuration
Signed-off-by: Adam Wolfe Gordon <awg@digitalocean.com>

@adamwg adamwg force-pushed the adamwg:awg/rbd-mirror-data-pool branch from 3486fe3 to 1e001c1 Aug 17, 2017

@adamwg

This comment has been minimized.

Copy link
Contributor Author

adamwg commented Aug 17, 2017

@dillaman I've added a note to the docs regarding pool names; please let me know if there are other spots that should be updated as well.

@dillaman

This comment has been minimized.

Copy link
Contributor

dillaman commented Aug 17, 2017

jenkins render docs

@ceph-jenkins

This comment has been minimized.

Copy link
Collaborator

ceph-jenkins commented Aug 17, 2017

Doc render available at http://docs.ceph.com/ceph-prs/17023/

@dillaman
Copy link
Contributor

dillaman left a comment

lgtm

@dillaman dillaman merged commit 31fbb50 into ceph:luminous Aug 17, 2017

5 checks passed

Docs: build check OK - docs built
Details
Docs: render build OK - docs rendered
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.