New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: rgw: S3 v4 auth fails when query string contains #17114

Merged
merged 3 commits into from Aug 24, 2017

Conversation

@theanalyst
Member

theanalyst commented Aug 21, 2017

zhangsw and others added some commits Jul 4, 2017

rgw: replace '+' with "%20" in canonical query string for s3 v4 auth.
( note: this patch modified: now replaces "+" with " ".  mwatts@redhat.com )

Fixes: http://tracker.ceph.com/issues/20501

Signed-off-by: Zhang Shaowen <zhangshaowen@cmss.chinamobile.com>
(cherry picked from commit 8ef21a0)
radosgw: fix zero sized chunked uploads with s3
s3 allows for zero sized objects, which can be
created using chunked uploads.  It is important to
call "recv_body (and ChunkMeta::create_next()) even
on zero sized objects, so that the proper chunk signature
can be presented at signature verification time.

Fixes: http://tracker.ceph.com/issues/21000

Signed-off-by: Marcus Watts <mwatts@redhat.com>
(cherry picked from commit 4d3d72f)
radosgw: fix small sized chunked uploads with s3
The logic to compute the number of bytes to copy with a chunked file
upload was failing to take into account the amount of data that had been
consumed, but was still pending in the parse buffer.  This would cause
strange behavior ranging from "just works" to "fails".  There was also a
strange "works, one byte at a time" mode.  Using the correct stream_pos
offset eliminates the bad behavior.

This fix also adds debug statements to make the correct behavior easier to see.

Fixes: http://tracker.ceph.com/issues/21003

Signed-off-by: Marcus Watts <mwatts@redhat.com>
(cherry picked from commit 96c4a26)

@theanalyst theanalyst self-assigned this Aug 21, 2017

@theanalyst theanalyst added this to the luminous milestone Aug 21, 2017

@theanalyst theanalyst requested review from rzarzynski and mattbenjamin Aug 21, 2017

@theanalyst theanalyst added rgw and removed core labels Aug 21, 2017

@theanalyst theanalyst changed the title from S3 v4 auth fails when query string contains to luminous: rgw: S3 v4 auth fails when query string contains Aug 21, 2017

@theanalyst theanalyst requested a review from smithfarm Aug 21, 2017

@theanalyst

This comment has been minimized.

Member

theanalyst commented Aug 21, 2017

jenkins test this please

1 similar comment
@theanalyst

This comment has been minimized.

Member

theanalyst commented Aug 21, 2017

jenkins test this please

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Aug 21, 2017

Jenkins re-test this please - apparently, the test_pidfile.sh failed - known issue? http://tracker.ceph.com/issues/20770

@theanalyst

This comment has been minimized.

Member

theanalyst commented Aug 21, 2017

strange that the other luminous backport passed then

@mattbenjamin

lgtm

@rzarzynski

LGTM.

@theanalyst

This comment has been minimized.

Member

theanalyst commented Aug 21, 2017

enkins re-test this please (the test_pidfile.sh failed)

@theanalyst

This comment has been minimized.

Member

theanalyst commented Aug 22, 2017

jenkins retest this please

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Aug 22, 2017

Sounds like we need to backport @dzafman 's test_pidfile.sh fixes as a matter of urgency.

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Aug 22, 2017

See #17161

@theanalyst

This comment has been minimized.

Member

theanalyst commented Aug 22, 2017

@smithfarm yes, agree

@liewegas liewegas merged commit 8f7bf7e into ceph:luminous Aug 24, 2017

3 of 4 checks passed

make check make check failed
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment