New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rgw: multisite: log_meta on secondary zone causes continuous loop of metadata sync #17148

Merged
merged 4 commits into from Sep 12, 2017

Conversation

Projects
None yet
6 participants

@smithfarm smithfarm self-assigned this Aug 22, 2017

@smithfarm smithfarm added this to the jewel milestone Aug 22, 2017

@smithfarm smithfarm changed the title from jewel: multisite: log_meta on secondary zone causes continuous loop of metadata sync to jewel: rgw: multisite: log_meta on secondary zone causes continuous loop of metadata sync Aug 22, 2017

@smithfarm smithfarm added rgw and removed core labels Aug 22, 2017

@amitkumar50

Sorry to add.
But why jewel's PR titles are longer?
What's PR title length for jewel as per 'Guidelines for Submitting ceph/jewel patch' says?

@mattbenjamin

This comment has been minimized.

Show comment
Hide comment
@mattbenjamin

mattbenjamin Aug 27, 2017

Contributor

@amitkumar50 isn't it just prepending "jewel: "? The folks adding this are either core members of the backport team or maintainers coordinating with them. I'd focus attention elsewhere to improve quality, as I think this is basically a best practice--or certainly a good one.

Contributor

mattbenjamin commented Aug 27, 2017

@amitkumar50 isn't it just prepending "jewel: "? The folks adding this are either core members of the backport team or maintainers coordinating with them. I'd focus attention elsewhere to improve quality, as I think this is basically a best practice--or certainly a good one.

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 27, 2017

Contributor

Yeah, the "jewel: " prefix on the PR title makes it immediately obvious that the PR is targeting a stable branch. This is useful when perusing lists of PRs in the github GUI, for example.

Contributor

smithfarm commented Aug 27, 2017

Yeah, the "jewel: " prefix on the PR title makes it immediately obvious that the PR is targeting a stable branch. This is useful when perusing lists of PRs in the github GUI, for example.

@amitkumar50

This comment has been minimized.

Show comment
Hide comment
@amitkumar50

amitkumar50 Aug 30, 2017

Contributor

@mattbenjamin Hey matt my point was not prepending 'jewel'. My point was why PR heading text is way bigger than 72 characters also?

Contributor

amitkumar50 commented Aug 30, 2017

@mattbenjamin Hey matt my point was not prepending 'jewel'. My point was why PR heading text is way bigger than 72 characters also?

@yehudasa

This comment has been minimized.

Show comment
Hide comment
@yehudasa

yehudasa Sep 12, 2017

Member

@smithfarm why is the filestore commit needed here?

Member

yehudasa commented Sep 12, 2017

@smithfarm why is the filestore commit needed here?

@yehudasa

maybe drop the filestore commit?

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Sep 12, 2017

Contributor

@yehudasa The filestore commit was part of https://github.com/ceph/ceph/pull/15777/commits so it was just cherry-picked along with the other commits in that PR. It looks like a "cleanup" type commit so I'll drop it.

Contributor

smithfarm commented Sep 12, 2017

@yehudasa The filestore commit was part of https://github.com/ceph/ceph/pull/15777/commits so it was just cherry-picked along with the other commits in that PR. It looks like a "cleanup" type commit so I'll drop it.

cbodley and others added some commits Jun 10, 2017

rgw: only log metadata on metadata master zone
Fixes: http://tracker.ceph.com/issues/20244

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit b8272f3)
rgw: log_meta only for more than one zone
Fixes: http://tracker.ceph.com/issues/20357
Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit 088dba0)
rgw: is_single_zonegroup doesn't use store or cct
Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit 0b0090c)
rgw: we no longer use log_meta
Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit ac8b007)
@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Sep 12, 2017

Contributor

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-63

Contributor

smithfarm commented Sep 12, 2017

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-63

@smithfarm smithfarm merged commit fbae112 into ceph:jewel Sep 12, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-20292-jewel branch Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment