Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create the ceph-volume and ceph-volume-systemd man pages #17152

Merged
merged 5 commits into from Aug 22, 2017

Conversation

Projects
None yet
3 participants
@alfredodeza
Copy link
Contributor

commented Aug 22, 2017

alfredodeza added some commits Aug 22, 2017

doc/man create the ceph-volume-systemd man page
Signed-off-by: Alfredo Deza <adeza@redhat.com>
doc/man create the ceph-volume man page
Signed-off-by: Alfredo Deza <adeza@redhat.com>
doc index the ceph-volume and ceph-volume-systemd man pages
Signed-off-by: Alfredo Deza <adeza@redhat.com>

@alfredodeza alfredodeza requested review from andrewschoen and ktdreyer Aug 22, 2017

@ktdreyer
Copy link
Member

left a comment

Awesome, thank you!

@ktdreyer

This comment has been minimized.

Copy link
Member

commented Aug 22, 2017

I think the RPM and Debian packaging will need updates to ship the generated nroff files

alfredodeza added some commits Aug 22, 2017

debian: include ceph-volume and ceph-volume-systemd man pages
Signed-off-by: Alfredo Deza <adeza@redhat.com>
rpm: include ceph-volume and ceph-volume-systemd man pages
Signed-off-by: Alfredo Deza <adeza@redhat.com>
@alfredodeza

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2017

@ktdreyer thank you for catching that, I have updated the Debian and RPM files to include the man pages

@alfredodeza

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2017

jenkins test docs

@ktdreyer

This comment has been minimized.

Copy link
Member

commented Aug 22, 2017

packaging LGTM

@alfredodeza alfredodeza merged commit e62a28c into master Aug 22, 2017

3 of 5 checks passed

make check running make check
Details
make check (arm64) running make check
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details

@alfredodeza alfredodeza deleted the wip-rm21030 branch Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.