New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rgw: multisite: RGWRadosRemoveOmapKeysCR::request_complete return val is wrong #17156

Merged
merged 1 commit into from Sep 12, 2017

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented Aug 22, 2017

rgw:multisite: fix RGWRadosRemoveOmapKeysCR
RGWRadosRemoveOmapKeysCR::request_complete return val is wrong. The return val should get from completion.  Some member variables is not used, clear up those variables.

Fixes:http://tracker.ceph.com/issues/20539

Signed-off-by: Shasha Lu <lu.shasha@eisoo.com>
(cherry picked from commit 82a0b6a)

Conflicts:
	src/rgw/rgw_cr_rados.cc (trivial resolution)
	src/rgw/rgw_cr_rados.h (master does not have IoCtx, jewel does not have override)

@smithfarm smithfarm self-assigned this Aug 22, 2017

@smithfarm smithfarm added this to the jewel milestone Aug 22, 2017

@smithfarm smithfarm changed the title from jewel: rgw:multisite: RGWRadosRemoveOmapKeysCR::request_complete return val is wrong to jewel: rgw: multisite: RGWRadosRemoveOmapKeysCR::request_complete return val is wrong Aug 22, 2017

@smithfarm smithfarm added rgw and removed core labels Aug 22, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Sep 12, 2017

Contributor

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-63

Contributor

smithfarm commented Sep 12, 2017

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-63

@smithfarm smithfarm merged commit 5b1e1cf into ceph:jewel Sep 12, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-20673-jewel branch Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment