New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rgw: not initialized pointer cause rgw crash with ec data pool #17164

Merged
merged 2 commits into from Sep 12, 2017

Conversation

Projects
None yet
5 participants
@smithfarm
Contributor

smithfarm commented Aug 22, 2017

fangyuxiangGL and others added some commits May 3, 2017

rgw: don't do unneccesary write if buffer with zero length
Don't do unneccesary write if buffer with zero length,
or there will be one more shadow stripe rados object with size 0

Signed-off-by: fang yuxiang <fang.yuxiang@eisoo.com>
(cherry picked from commit 4e21f7e)
rgw: fix not initialized pointer which cause rgw crash with ec data pool
In RGWPutObjProcessor_Atomic::complete_writing_data()
with pending_data_bl.length() > 0 and next_part_ofs==data_ofs
not initialized void *handle leads to invalid pointer librados::AioCompletion::pc
which leads to rgw crash.

Fixes: http://tracker.ceph.com/issues/20542
Signed-off-by: Aleksei Gutikov <aleksey.gutikov@synesis.ru>
(cherry picked from commit 3e938dd)

Conflicts:
	src/rgw/rgw_rados.cc (trivial resolution)

@smithfarm smithfarm self-assigned this Aug 22, 2017

@smithfarm smithfarm added this to the jewel milestone Aug 22, 2017

@smithfarm smithfarm added bug fix core rgw and removed core labels Aug 22, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Sep 12, 2017

Contributor

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-63

Contributor

smithfarm commented Sep 12, 2017

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-63

@smithfarm smithfarm merged commit 89b00a8 into ceph:jewel Sep 12, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-20712-jewel branch Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment