New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rgw: radosgw-admin data sync run crash #17165

Merged
merged 1 commit into from Sep 12, 2017

Conversation

Projects
None yet
4 participants
@smithfarm
Contributor

smithfarm commented Aug 22, 2017

@smithfarm smithfarm self-assigned this Aug 22, 2017

@smithfarm smithfarm added this to the jewel milestone Aug 22, 2017

@smithfarm smithfarm added bug fix core rgw and removed core labels Aug 22, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 22, 2017

Contributor

Jenkins re-test this please (fatal: unable to access 'https://github.com/ceph/ceph.git/': Could not resolve host: github.com)

Contributor

smithfarm commented Aug 22, 2017

Jenkins re-test this please (fatal: unable to access 'https://github.com/ceph/ceph.git/': Could not resolve host: github.com)

rgw: fix radosgw-admin data sync run crash
If sync thread have run before, then run data sync init. sync_status is still remain in rados pool. so no matter sync_status exists or not, if state is StateInit, sync_status.sync_info.num_shards should be updated.

Fixes: http://tracker.ceph.com/issues/20423

Signed-off-by: Shasha Lu <lu.shasha@eisoo.com>
(cherry picked from commit c307910)

Conflicts:
    src/rgw/rgw_data_sync.cc (no data_sync_module or instance_id in jewel)
@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Sep 12, 2017

Contributor

Re-did the cherry-pick to resolve conflict with a recently merged PR.

Contributor

smithfarm commented Sep 12, 2017

Re-did the cherry-pick to resolve conflict with a recently merged PR.

@yehudasa

This comment has been minimized.

Show comment
Hide comment
@yehudasa
Member

yehudasa commented Sep 12, 2017

@smithfarm lgtm

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Sep 12, 2017

Contributor

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-63

Contributor

smithfarm commented Sep 12, 2017

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-63

@smithfarm smithfarm merged commit 9084ce8 into ceph:jewel Sep 12, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-20715-jewel branch Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment