New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: mon/OSDMonitor: do not send_pg_creates with stale info #17191

Merged
merged 1 commit into from Aug 24, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented Aug 23, 2017

we reset the "creating_pgs" with the newly accepted paxos proposal, but
the creating_pgs_by_osd_epoch is out-of-sync with the new creating_pgs.
so we are at risk of using stale creating_pgs_by_osd_epoch along with
the new creating_pgs.pgs. to avoid this racing, we need to check the
creating_pgs_epoch before sending pg-creates using
creating_pgs_by_osd_epoch.

Fixes: http://tracker.ceph.com/issues/20785
Signed-off-by: Kefu Chai kchai@redhat.com
(cherry picked from commit 689cf03)

@tchaikov tchaikov added this to the luminous milestone Aug 23, 2017

mon/OSDMonitor: do not send_pg_creates with stale info
we reset the "creating_pgs" with the newly accepted paxos proposal, but
the creating_pgs_by_osd_epoch is out-of-sync with the new creating_pgs.
so we are at risk of using stale creating_pgs_by_osd_epoch along with
the new creating_pgs.pgs. to avoid this racing, we need to check the
creating_pgs_epoch before sending pg-creates using
creating_pgs_by_osd_epoch.

Fixes: http://tracker.ceph.com/issues/20785
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 689cf03)

@liewegas liewegas merged commit 60c06ca into ceph:luminous Aug 24, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-luminous-pr-17065 branch Aug 24, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Sep 4, 2017

backport of #17065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment