New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: Include front/back interface names in OSD metadata #17193

Merged
merged 2 commits into from Aug 24, 2017

Conversation

Projects
None yet
3 participants
@theanalyst
Member

theanalyst commented Aug 23, 2017

John Spray added some commits Aug 9, 2017

common: return iface instead of addr from ipaddr.cc helpers
So that we can use the same helper functions to look
up interface names that we use to look up addresses.

Signed-off-by: John Spray <john.spray@redhat.com>
(cherry picked from commit 687ea10)
osd: include front_iface+back_iface in metadata
Fixes: http://tracker.ceph.com/issues/20956
Signed-off-by: John Spray <john.spray@redhat.com>
(cherry picked from commit 79491c1)

@theanalyst theanalyst self-assigned this Aug 23, 2017

@theanalyst theanalyst added this to the luminous milestone Aug 23, 2017

@theanalyst theanalyst requested a review from tchaikov Aug 23, 2017

@theanalyst theanalyst requested a review from liewegas Aug 23, 2017

@liewegas liewegas merged commit 46cf776 into ceph:luminous Aug 24, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@@ -5901,6 +5902,17 @@ void OSD::_collect_metadata(map<string,string> *pm)
collect_sys_info(pm, cct);
std::string front_iface, back_iface;

This comment has been minimized.

@tchaikov

tchaikov Aug 24, 2017

Contributor

fyi, this chunk of code was removed by #17131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment