New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fix accessing expired memory in PrefixableSignatureHelper. #17206

Merged
merged 1 commit into from Aug 30, 2017

Conversation

Projects
None yet
3 participants
@rzarzynski
Contributor

rzarzynski commented Aug 23, 2017

Fixes: http://tracker.ceph.com/issues/21085
Signed-off-by: Radoslaw Zarzynski rzarzyns@redhat.com

Show outdated Hide outdated src/rgw/rgw_swift_auth.cc
rgw: fix accessing expired memory in PrefixableSignatureHelper.
Fixes: http://tracker.ceph.com/issues/21085
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

@cbodley cbodley added the needs-qa label Aug 24, 2017

@rzarzynski

This comment has been minimized.

Show comment
Hide comment
@rzarzynski

rzarzynski Aug 24, 2017

Contributor

The patch has been tested with Swift's functional tests:

http://qa-proxy.ceph.com/teuthology/rzarzynski-2017-08-23_15:23:33-rgw-wip-rzarzynski-testing---basic-mira/1555012/remote/mira041/log/valgrind/cep

$ SWIFT_TEST_CONFIG_FILE=rgw.conf nosetests -v test.functional.test_tempurl:TestTempURLPrefix
...
SKIPPING FUNCTIONAL TESTS SPECIFIC TO AUTH VERSION 3
SKIPPING FUNCTIONAL TESTS SPECIFIC TO SERVICE TOKENS
SKIPPING FUNCTIONAL TESTS DUE TO NO CONFIG FOR RESELLER ADMIN
SKIPPING FUNCTIONAL TESTS SPECIFIC TO AUTH VERSION 3
SKIPPING FUNCTIONAL TESTS SPECIFIC TO SERVICE TOKENS
SKIPPING FUNCTIONAL TESTS DUE TO NO CONFIG FOR RESELLER ADMIN
test_GET (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_GET_DLO_inside_container (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_GET_DLO_outside_container (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_GET_with_key_2 (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_HEAD (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_PUT (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_PUT_manifest_access (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_changing_expires (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_changing_sig (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_different_object (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_empty_prefix (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_missing_query_parm (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_no_prefix_match (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_object_url_with_prefix (test.functional.test_tempurl.TestTempURLPrefix) ... ok

----------------------------------------------------------------------
Ran 14 tests in 1.606s

OK
Contributor

rzarzynski commented Aug 24, 2017

The patch has been tested with Swift's functional tests:

http://qa-proxy.ceph.com/teuthology/rzarzynski-2017-08-23_15:23:33-rgw-wip-rzarzynski-testing---basic-mira/1555012/remote/mira041/log/valgrind/cep

$ SWIFT_TEST_CONFIG_FILE=rgw.conf nosetests -v test.functional.test_tempurl:TestTempURLPrefix
...
SKIPPING FUNCTIONAL TESTS SPECIFIC TO AUTH VERSION 3
SKIPPING FUNCTIONAL TESTS SPECIFIC TO SERVICE TOKENS
SKIPPING FUNCTIONAL TESTS DUE TO NO CONFIG FOR RESELLER ADMIN
SKIPPING FUNCTIONAL TESTS SPECIFIC TO AUTH VERSION 3
SKIPPING FUNCTIONAL TESTS SPECIFIC TO SERVICE TOKENS
SKIPPING FUNCTIONAL TESTS DUE TO NO CONFIG FOR RESELLER ADMIN
test_GET (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_GET_DLO_inside_container (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_GET_DLO_outside_container (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_GET_with_key_2 (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_HEAD (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_PUT (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_PUT_manifest_access (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_changing_expires (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_changing_sig (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_different_object (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_empty_prefix (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_missing_query_parm (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_no_prefix_match (test.functional.test_tempurl.TestTempURLPrefix) ... ok
test_object_url_with_prefix (test.functional.test_tempurl.TestTempURLPrefix) ... ok

----------------------------------------------------------------------
Ran 14 tests in 1.606s

OK

@yuriw yuriw merged commit 8c8d38c into ceph:master Aug 30, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment