New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: core: disable skewed utilization warning by default #17210

Merged
merged 1 commit into from Sep 5, 2017

Conversation

Projects
None yet
5 participants
@dzafman
Member

dzafman commented Aug 23, 2017

This has a few problems:

1- It does not do it's analysis over CRUSH rule roots/classes, which
means that an innocent user of classes will see skewed usage (bc hdds are
more full than ssds, say)

2- It does not take degraded clusters into account, which means the warning
will appear when a fresh OSD is added.

See http://tracker.ceph.com/issues/20730

Signed-off-by: David Zafman dzafman@redhat.com

@dzafman dzafman added this to the jewel milestone Aug 23, 2017

@dzafman dzafman changed the title from config: disable skewed utilization warning by default to Jewel: config: disable skewed utilization warning by default Aug 23, 2017

@dzafman dzafman requested a review from liewegas Aug 23, 2017

@liewegas liewegas added the core label Aug 24, 2017

@smithfarm smithfarm changed the title from Jewel: config: disable skewed utilization warning by default to jewel: core: disable skewed utilization warning by default Aug 24, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 24, 2017

Contributor

@dzafman Can you add a sentence to the commit message conveying the following idea: "Based on master commit 7832c53 which cannot be cherry-picked because . . . (insert reasoning here) . . ."

Contributor

smithfarm commented Aug 24, 2017

@dzafman Can you add a sentence to the commit message conveying the following idea: "Based on master commit 7832c53 which cannot be cherry-picked because . . . (insert reasoning here) . . ."

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 24, 2017

Contributor

Jenkins re-test this please (timeout)

Contributor

smithfarm commented Aug 24, 2017

Jenkins re-test this please (timeout)

config: disable skewed utilization warning by default
This has a few problems:

1- It does not do it's analysis over CRUSH rule roots/classes, which
means that an innocent user of classes will see skewed usage (bc hdds are
more full than ssds, say)

2- It does not take degraded clusters into account, which means the warning
will appear when a fresh OSD is added.

See http://tracker.ceph.com/issues/20730

Based on master commit 7832c53 but we've decided not to remove the code
in the older releases so it can be used if appropriate for a
particular cluster configuration.  Also, 7832c53 won't cleanly
cherry-pick so this is easier.

Signed-off-by: David Zafman <dzafman@redhat.com>
@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Sep 3, 2017

Contributor

@jdurgin This passed a rados run at http://tracker.ceph.com/issues/20613#note-40 with some failures, all of which I tried to reproduce. The only one that is reliably reproducible is http://tracker.ceph.com/issues/20981

@liewegas has already reviewed it, so I'll go ahead and merge unless there are objections.

Contributor

smithfarm commented Sep 3, 2017

@jdurgin This passed a rados run at http://tracker.ceph.com/issues/20613#note-40 with some failures, all of which I tried to reproduce. The only one that is reliably reproducible is http://tracker.ceph.com/issues/20981

@liewegas has already reviewed it, so I'll go ahead and merge unless there are objections.

@smithfarm smithfarm requested a review from jdurgin Sep 3, 2017

@jdurgin

jdurgin approved these changes Sep 5, 2017

@jdurgin jdurgin merged commit c93d2c6 into ceph:jewel Sep 5, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment