New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: mon/OSDMonitor: fix improper input/testing range of crush somke testing #17232

merged 1 commit into from Aug 25, 2017


None yet
3 participants

tchaikov commented Aug 24, 2017

backport #17179

mon/OSDMonitor: fix improper input/testing range of crush somke testing
CrushTester::test() will reset testing range to [0, 1023] whenever
min_x or max_x is negative and the constructor of CrushTester will
always default min_x and max_x to -1.

Thus to set the test range correctly, you have to specify both min_x and max_x.
Local test shows this patch shall decrease the time consumed by the crush
smoke testing to approximate 1/20 of those without this.

For exmaple:
crush somke test duration: 0.668354 seconds ->
crush somke test duration: 0.012592 seconds

Signed-off-by: xie xingguo <>
(cherry picked from commit e128a1e)

@tchaikov tchaikov added this to the luminous milestone Aug 24, 2017


This comment has been minimized.

@liewegas liewegas merged commit 516951e into ceph:luminous Aug 25, 2017

4 of 5 checks passed

make check make check failed
Docs: build check OK - docs built
Signed-off-by all commits in this PR are signed
Unmodified Submodules submodules for project are unmodified
make check (arm64) make check succeeded

@tchaikov tchaikov deleted the tchaikov:wip-luminous-pr-17179 branch Aug 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment