New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: os/bluestore: compensate for bad freelistmanager size/blocks metadata #17273

Merged
merged 1 commit into from Aug 27, 2017

Conversation

Projects
None yet
2 participants
@xiexingguo
Copy link
Member

xiexingguo commented Aug 27, 2017

This repairs bluestores created before http://tracker.ceph.com/issues/21089
was fixed in f6f1ae3.

In both cases, the freelistmanager's size is off by one block (4k). In
one case, it is just a matter of fixing the size and twiddling the trailing
bit. In the second case, the size delta causes freelistmanager to need
a new row, which means the blocks count also changes, and we have lots
of bits to zero (all but one in the new row).

Both are silently corrected by fsck in this patch.

Fixes: http://tracker.ceph.com/issues/21089
Signed-off-by: Sage Weil sage@redhat.com
(cherry picked from commit c029a96)

os/bluestore: compensate for bad freelistmanager size/blocks metadata
This repairs bluestores created before http://tracker.ceph.com/issues/21089
was fixed in f6f1ae3.

In both cases, the freelistmanager's size is off by one block (4k).  In
one case, it is just a matter of fixing the size and twiddling the trailing
bit.  In the second case, the size delta causes freelistmanager to need
a new row, which means the blocks count also changes, and we have lots
of bits to zero (all but one in the new row).

Both are silently corrected by fsck in this patch.

Fixes: http://tracker.ceph.com/issues/21089
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit c029a96)

@xiexingguo xiexingguo added this to the luminous milestone Aug 27, 2017

@liewegas liewegas merged commit 140e8b3 into ceph:luminous Aug 27, 2017

3 of 4 checks passed

make check running make check
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details

@xiexingguo xiexingguo deleted the xiexingguo:wip-luminous-pr-17268 branch Aug 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment