New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: cephfs: get_quota_root sends lookupname op for every buffered write #17396

Merged
merged 1 commit into from Sep 7, 2017

Conversation

Projects
None yet
4 participants
@smithfarm
Contributor

smithfarm commented Aug 31, 2017

client: skip lookupname if writing to unlinked file
When a client writes to an unlinked file, get_quota_root tries to
resolve the filename via an MDS lookupname op. The op always results in
-13 permission denied for path-restricted caps or -2 no such file or
directory otherwise. More importantly, the repeated lookupname ops slow
down buffered writes significantly.

Don't do the lookupname for unlinked files; use the root_ancentor's
quota instead.

Fixes: http://tracker.ceph.com/issues/20945
Backport: jewel, luminous
Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
(cherry picked from commit 1d617ee)

@smithfarm smithfarm self-assigned this Aug 31, 2017

@smithfarm smithfarm added this to the jewel milestone Aug 31, 2017

@smithfarm smithfarm changed the title from jewel: get_quota_root sends lookupname op for every buffered write to jewel: cephfs: get_quota_root sends lookupname op for every buffered write Aug 31, 2017

@smithfarm smithfarm added cephfs and removed core labels Aug 31, 2017

@amitkumar50

It looks already present on current master.

@ukernel

ukernel approved these changes Sep 6, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Sep 7, 2017

Contributor
Contributor

smithfarm commented Sep 7, 2017

@smithfarm smithfarm merged commit b2accb8 into ceph:jewel Sep 7, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-21113-jewel branch Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment