Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/PGMap: drop DISK LOG column #17617

Merged
merged 1 commit into from Sep 14, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Copy link
Member

commented Sep 10, 2017

We can re-add it if/when it differs from LOG.

Signed-off-by: Sage Weil sage@redhat.com

mon/PGMap: drop DISK LOG column
We can re-add it if/when it differs from LOG.

Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas requested a review from tchaikov Sep 10, 2017

@tchaikov
Copy link
Contributor

left a comment

can we just completely ditch ondisk_log_size?

@liewegas

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2017

I thought about that, but it seems conceivable that we'll allow a way for pg logs to exist on disk and not in ram, in which case we'd have to re-add the field again.

@tchaikov tchaikov merged commit eb8bfd1 into ceph:master Sep 14, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-drop-disk-log branch Sep 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.