Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krbd: rewrite "already mapped" code #17638

Merged
merged 3 commits into from Sep 11, 2017

Conversation

Projects
None yet
2 participants
@idryomov
Copy link
Contributor

commented Sep 11, 2017

No description provided.

idryomov added some commits Sep 7, 2017

krbd: factor out enumerate_devices()
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
krbd: rewrite "already mapped" code
The "already mapped" code, introduced in commit d6a66fc ("rbd:
before rbd map, warn if the image is already mapped") is broken:
because of a use-after-free on attribute strings, the warning isn't
even printed half the time.

Rewrite making use of udev enumeration filters and fix the interface
while at it.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
tests: update unmap.t for "already mapped" warning
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
@dillaman
Copy link
Contributor

left a comment

lgtm

@dillaman dillaman added the needs-qa label Sep 11, 2017

@dillaman dillaman merged commit b1644fd into ceph:master Sep 11, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@idryomov idryomov deleted the idryomov:wip-rbd-already-mapped-fixes branch Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.